Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: IB/qib: Add congestion control agent implementation
Date: Fri, 20 Jul 2012 14:05:28 +0300	[thread overview]
Message-ID: <20120720110528.GA31382@elgon.mountain> (raw)

Hello Mike Marciniszyn,

The patch 36a8f01cd24b: "IB/qib: Add congestion control agent
implementation" from Jul 19, 2012, leads to the following warning:
drivers/infiniband/hw/qib/qib_init.c:230 qib_init_pportdata()
	 warn: value 1984 can't fit into 255 'ppd->cc_supported_table_entries'

drivers/infiniband/hw/qib/qib_init.c
   227          if (qib_cc_table_size < IB_CCT_MIN_ENTRIES)
   228                  goto bail;
   229  
   230          ppd->cc_supported_table_entries = min(max_t(int, qib_cc_table_size,
   231                  IB_CCT_MIN_ENTRIES), IB_CCT_ENTRIES*IB_CC_TABLE_CAP_DEFAULT);
                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
						64 * 31 = 1984
->cc_supported_table_entries is a u8 so 1984 gets truncated.

   232  
   233          ppd->cc_max_table_entries =
   234                  ppd->cc_supported_table_entries/IB_CCT_ENTRIES;
   235  

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

                 reply	other threads:[~2012-07-20 11:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120720110528.GA31382@elgon.mountain \
    --to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox