* re: IB/qib: Add congestion control agent implementation
@ 2012-07-20 11:05 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-07-20 11:05 UTC (permalink / raw)
To: mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Hello Mike Marciniszyn,
The patch 36a8f01cd24b: "IB/qib: Add congestion control agent
implementation" from Jul 19, 2012, leads to the following warning:
drivers/infiniband/hw/qib/qib_init.c:230 qib_init_pportdata()
warn: value 1984 can't fit into 255 'ppd->cc_supported_table_entries'
drivers/infiniband/hw/qib/qib_init.c
227 if (qib_cc_table_size < IB_CCT_MIN_ENTRIES)
228 goto bail;
229
230 ppd->cc_supported_table_entries = min(max_t(int, qib_cc_table_size,
231 IB_CCT_MIN_ENTRIES), IB_CCT_ENTRIES*IB_CC_TABLE_CAP_DEFAULT);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
64 * 31 = 1984
->cc_supported_table_entries is a u8 so 1984 gets truncated.
232
233 ppd->cc_max_table_entries =
234 ppd->cc_supported_table_entries/IB_CCT_ENTRIES;
235
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-20 11:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-20 11:05 IB/qib: Add congestion control agent implementation Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).