From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 3/8] libibverbs: Introduce XRC domains Date: Mon, 24 Sep 2012 14:36:18 -0600 Message-ID: <20120924203618.GC9472@obsidianresearch.com> References: <1828884A29C6694DAF28B7E6B8A8237346A8E7FB@ORSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237346A8E7FB-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)" List-Id: linux-rdma@vger.kernel.org On Thu, Sep 20, 2012 at 09:43:06PM +0000, Hefty, Sean wrote: > +struct ibv_xrcd *__ibv_open_xrcd(struct ibv_context *context, int fd, int oflags) > +{ > + struct verbs_context *context_ex = verbs_get_ctx(context); > + struct ibv_xrcd *xrcd; This patch series seems to be missing the checks against a null return of verbs_get_ctx - if the driver is not extended these functions should return ENOSYS, not crash.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html