From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH for-next 0/4] IP based RoCE GID Addressing
Date: Thu, 13 Jun 2013 11:00:11 -0600 [thread overview]
Message-ID: <20130613170011.GA21570@obsidianresearch.com> (raw)
In-Reply-To: <1371135704-5712-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Thu, Jun 13, 2013 at 06:01:40PM +0300, Or Gerlitz wrote:
> Currently, the IB stack (core + drivers) handle RoCE (IBoE) gids as
> they encode related Ethernet net-device interface MAC address and
> possibly VLAN id.
>
> This series changes RoCE GIDs to encode IP addresses (IPv4 + IPv6)
> of the that Ethernet interface, under the following reasoning:
Can you talk abit about compatibility please?
What happens when nodes with this patch are on the same network as
nodes without it?
Does this patch remove the encoding of the VLAN from the GID?
How is the destination MAC derived now?
There is a RoCE standard, it doesn't say much, but how the MAC and GRH
GID are related/derived really should be specified...
Not sure about copying the IP/IPv6 address from the interface into the
HW, there has always been pressure to keep verbs separate from the net
stack.. At the very least patch #2 should have its change log updated
to actually reflect what is in the patch.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-13 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 15:01 [PATCH for-next 0/4] IP based RoCE GID Addressing Or Gerlitz
[not found] ` <1371135704-5712-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-06-13 15:01 ` [PATCH for-next 1/4] IB/core: RoCE IP based GID addressing Or Gerlitz
2013-06-13 15:01 ` [PATCH for-next 2/4] IB/mlx4: " Or Gerlitz
2013-06-13 15:01 ` [PATCH for-next 3/4] IB/core: Infra-structure to support verbs extensions through uverbs Or Gerlitz
2013-06-13 15:01 ` [PATCH for-next 4/4] IB/core: Add RoCE IP based addressing extensions towards user space Or Gerlitz
[not found] ` <1371135704-5712-5-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-06-13 17:09 ` Jason Gunthorpe
[not found] ` <20130613170939.GB21570-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2013-06-14 20:42 ` Or Gerlitz
2013-06-13 17:00 ` Jason Gunthorpe [this message]
[not found] ` <20130613170011.GA21570-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2013-06-14 20:35 ` [PATCH for-next 0/4] IP based RoCE GID Addressing Or Gerlitz
[not found] ` <CALsNU1PdjV2N4c3j9gQ0BRrd4GhOypDMMjmHEgF1ffCYOXeC1g@mail.gmail.com>
[not found] ` <CALsNU1PdjV2N4c3j9gQ0BRrd4GhOypDMMjmHEgF1ffCYOXeC1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-16 3:30 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613170011.GA21570@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox