public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	moshel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 1/2] mlx5: Use simple_open when possible
Date: Mon, 8 Jul 2013 20:34:03 +0800	[thread overview]
Message-ID: <20130708123403.GA10667@localhost> (raw)
In-Reply-To: <1373286607-3110-2-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Hi Or,

>  static const struct file_operations limit_fops = {
>  	.owner	= THIS_MODULE,
> -	.open	= file_open,
> +	.open = simple_open,
>  	.write	= limit_write,
>  	.read	= limit_read,

>  static const struct file_operations dfops = {
>  	.owner	= THIS_MODULE,
> -	.open	= dbg_open,
> +	.open = simple_open,
>  	.write	= data_write,
>  	.read	= data_read,
>  };
> @@ -1003,7 +996,7 @@ static ssize_t outlen_write(struct file *filp, const char __user *buf,
>  
>  static const struct file_operations olfops = {
>  	.owner	= THIS_MODULE,
> -	.open	= dbg_open,
> +	.open = simple_open,
>  	.write	= outlen_write,
>  	.read	= outlen_read,

>  static const struct file_operations fops = {
>  	.owner	= THIS_MODULE,
> -	.open	= dbg_open,
> +	.open = simple_open,
>  	.read	= dbg_read,
>  };

The above chunks will need to fix alignments.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2013-07-08 12:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08 12:30 [PATCH 0/2] Fixes to issues in mlx5 code found by static checker Or Gerlitz
     [not found] ` <1373286607-3110-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-07-08 12:30   ` [PATCH 1/2] mlx5: Use simple_open when possible Or Gerlitz
     [not found]     ` <1373286607-3110-2-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-07-08 12:34       ` Fengguang Wu [this message]
2013-07-08 12:57         ` Or Gerlitz
2013-07-08 12:30   ` [PATCH 2/2] IB/mlx5: Removes unneeded semicolons Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130708123403.GA10667@localhost \
    --to=fengguang.wu-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=moshel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox