From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org,
tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH V7 libibverbs 0/7] Add extension and XRC QP support
Date: Thu, 11 Jul 2013 11:07:10 -0600 [thread overview]
Message-ID: <20130711170710.GB27357@obsidianresearch.com> (raw)
In-Reply-To: <1373555063-31790-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Thu, Jul 11, 2013 at 06:04:16PM +0300, Yishai Hadas wrote:
> ABI support with OFED release, added place holder for 6 function pointers
> in verbs_context to enable ABI compatibility with OFED release that already
> used 6 extended verbs before XRC.
WTF !?!
The extension mechanism is NOT A TOY.
IT IS NOT FOR VENDORS TO USE.
Extension ids must be allocated at upstream, by Roland.
If you deviate from upstream you *MUST* change the ibverbs SONAME.
PERIOD.
What version of OFA OFED did this? This is a violation of the new
upstream first policy at OFA!
So, I'm going to NAK this. It sets an exceedingly bad precedent going
forward.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-07-11 17:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 15:04 [PATCH V7 libibverbs 0/7] Add extension and XRC QP support Yishai Hadas
[not found] ` <1373555063-31790-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-07-11 15:04 ` [PATCH V7 libibverbs 1/7] Infrastructure to support verbs extensions Yishai Hadas
2013-07-11 15:04 ` [PATCH V7 libibverbs 2/7] Introduce XRC domains Yishai Hadas
2013-07-11 15:04 ` [PATCH V7 libibverbs 3/7] Add support for XRC SRQs Yishai Hadas
2013-07-11 15:04 ` [PATCH V7 libibverbs 4/7] Add support for XRC QPs Yishai Hadas
2013-07-11 15:04 ` [PATCH V7 libibverbs 5/7] Add ibv_open_qp Yishai Hadas
2013-07-11 15:04 ` [PATCH V7 libibverbs 6/7] XRC man pages Yishai Hadas
2013-07-11 15:04 ` [PATCH V7 libibverbs 7/7] Add XRC sample application Yishai Hadas
2013-07-11 17:07 ` Jason Gunthorpe [this message]
[not found] ` <20130711170710.GB27357-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2013-07-15 12:40 ` [PATCH V7 libibverbs 0/7] Add extension and XRC QP support Yishai Hadas
[not found] ` <51E3EDCF.2050007-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-07-16 0:10 ` Jason Gunthorpe
[not found] ` <20130716001046.GA9237-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2013-07-18 20:06 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711170710.GB27357@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
--cc=tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox