From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>,
"linux-rdma
(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH infiniband-diags] infiniband-diags: Eliminate unneeded clean_nodedesc calls
Date: Thu, 18 Jul 2013 15:14:51 -0700 [thread overview]
Message-ID: <20130718151451.97f72b6601246725d8249130@intel.com> (raw)
In-Reply-To: <51E40808.4040907-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Mon, 15 Jul 2013 10:32:40 -0400
Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:
>
> in ibroute and dump_fts
> clean_nodedesc is called if needed within remap_node_name
>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks, accepted,
Ira
> ---
> diff --git a/src/dump_fts.c b/src/dump_fts.c
> index 89f0dce..5383c9d 100644
> --- a/src/dump_fts.c
> +++ b/src/dump_fts.c
> @@ -154,7 +154,7 @@ void dump_multicast_tables(ibnd_node_t * node, unsigned startlid,
> endlid = IB_MAX_MCAST_LID;
> }
>
> - mapnd = remap_node_name(node_name_map, nodeguid, clean_nodedesc(nd));
> + mapnd = remap_node_name(node_name_map, nodeguid, nd);
>
> printf("Multicast mlids [0x%x-0x%x] of switch %s guid 0x%016" PRIx64
> " (%s):\n", startlid, endlid, portid2str(portid), nodeguid,
> @@ -289,7 +289,7 @@ int dump_lid(char *str, int str_len, int lid, int valid,
> *last_port_lid = baselid + (1 << lmc) - 1;
> }
>
> - mapnd = remap_node_name(node_name_map, nodeguid, clean_nodedesc(nd));
> + mapnd = remap_node_name(node_name_map, nodeguid, nd);
>
> rc = snprintf(str, str_len, ": (%s portguid %s: '%s')",
> mad_dump_val(IB_NODE_TYPE_F, ntype, sizeof ntype,
> @@ -331,7 +331,7 @@ void dump_unicast_tables(ibnd_node_t * node, int startlid, int endlid,
> endlid = IB_MAX_UCAST_LID;
> }
>
> - mapnd = remap_node_name(node_name_map, nodeguid, clean_nodedesc(nd));
> + mapnd = remap_node_name(node_name_map, nodeguid, nd);
>
> printf("Unicast lids [0x%x-0x%x] of switch %s guid 0x%016" PRIx64
> " (%s):\n", startlid, endlid, portid2str(portid), nodeguid,
> diff --git a/src/ibroute.c b/src/ibroute.c
> index d4827c9..350a557 100644
> --- a/src/ibroute.c
> +++ b/src/ibroute.c
> @@ -178,7 +178,7 @@ char *dump_multicast_tables(ib_portid_t * portid, unsigned startlid,
> endlid = IB_MAX_MCAST_LID;
> }
>
> - mapnd = remap_node_name(node_name_map, nodeguid, clean_nodedesc(nd));
> + mapnd = remap_node_name(node_name_map, nodeguid, nd);
>
> printf("Multicast mlids [0x%x-0x%x] of switch %s guid 0x%016" PRIx64
> " (%s):\n", startlid, endlid, portid2str(portid), nodeguid,
> @@ -309,7 +309,7 @@ int dump_lid(char *str, int strlen, int lid, int valid)
> last_port_lid = baselid + (1 << lmc) - 1;
> }
>
> - mapnd = remap_node_name(node_name_map, nodeguid, clean_nodedesc(nd));
> + mapnd = remap_node_name(node_name_map, nodeguid, nd);
>
> rc = snprintf(str, strlen, ": (%s portguid %s: '%s')",
> mad_dump_val(IB_NODE_TYPE_F, ntype, sizeof ntype,
> @@ -348,7 +348,7 @@ char *dump_unicast_tables(ib_portid_t * portid, int startlid, int endlid)
> endlid = IB_MAX_UCAST_LID;
> }
>
> - mapnd = remap_node_name(node_name_map, nodeguid, clean_nodedesc(nd));
> + mapnd = remap_node_name(node_name_map, nodeguid, nd);
>
> printf("Unicast lids [0x%x-0x%x] of switch %s guid 0x%016" PRIx64
> " (%s):\n", startlid, endlid, portid2str(portid), nodeguid,
--
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-07-18 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 14:32 [PATCH infiniband-diags] infiniband-diags: Eliminate unneeded clean_nodedesc calls Hal Rosenstock
[not found] ` <51E40808.4040907-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-07-18 22:14 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130718151451.97f72b6601246725d8249130@intel.com \
--to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=weiny2-i2BcT+NCU+M@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox