re: iser-target: introduce fast memory registration mode (FRWR)

re: iser-target: introduce fast memory registration mode (FRWR)

[Dan Carpenter]

Hello Vu Pham,

This is a semi-automatic email about new static checker warnings.

The patch 12050ce23475: "iser-target: introduce fast memory 
registration mode (FRWR)" from Aug 28, 2013, leads to the following 
Smatch complaint:

drivers/infiniband/ulp/isert/ib_isert.c:622 isert_connect_release()
	 warn: variable dereferenced before check 'device' (see line 598)

drivers/infiniband/ulp/isert/ib_isert.c
   597		if (device->use_frwr)
                    ^^^^^^^^^^^^^^^^
Patch introduces dereference.

   598			isert_conn_free_frwr_pool(isert_conn);
   599	

[ snip ]

   620		kfree(isert_conn);
   621	
   622		if (device)
                    ^^^^^^
Existing check.

   623			isert_device_try_release(device);
   624	

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: iser-target: introduce fast memory registration mode (FRWR)

[Dan Carpenter]

What ever happened with this?

regards,
dan carpenter

On Tue, Sep 03, 2013 at 02:14:36PM +0300, Dan Carpenter wrote:
> Hello Vu Pham,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch 12050ce23475: "iser-target: introduce fast memory 
> registration mode (FRWR)" from Aug 28, 2013, leads to the following 
> Smatch complaint:
> 
> drivers/infiniband/ulp/isert/ib_isert.c:622 isert_connect_release()
> 	 warn: variable dereferenced before check 'device' (see line 598)
> 
> drivers/infiniband/ulp/isert/ib_isert.c
>    597		if (device->use_frwr)
>                     ^^^^^^^^^^^^^^^^
> Patch introduces dereference.
> 
>    598			isert_conn_free_frwr_pool(isert_conn);
>    599	
> 
> [ snip ]
> 
>    620		kfree(isert_conn);
>    621	
>    622		if (device)
>                     ^^^^^^
> Existing check.
> 
>    623			isert_device_try_release(device);
>    624	
> 
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html