Re: [PATCH RFC 06/77] PCI/MSI: Factor out pci_get_msi_cap() interface

Alexander Gordeev
2013-10-04T05:13:24Z

On Thu, Oct 03, 2013 at 10:52:54PM +0100, Ben Hutchings wrote:
> On Wed, 2013-10-02 at 12:48 +0200, Alexander Gordeev wrote:
> > #ifndef CONFIG_PCI_MSI
> > +static inline int pci_get_msi_cap(struct pci_dev *dev)
> > +{
> > + return -1;
> [...]
>
> Shouldn't this also return -EINVAL?

Yep, all inliners here are better to return -EINVAL.
Will do unless someone speaks out against.

> Ben.

--
Regards,
Alexander Gordeev
agordeev@redhat.com