From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: iser-target: introduce fast memory registration mode (FRWR)
Date: Sat, 19 Oct 2013 11:29:10 +0300 [thread overview]
Message-ID: <20131019082910.GK5550@mwanda> (raw)
In-Reply-To: <20130903111436.GA15230-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
What ever happened with this?
regards,
dan carpenter
On Tue, Sep 03, 2013 at 02:14:36PM +0300, Dan Carpenter wrote:
> Hello Vu Pham,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 12050ce23475: "iser-target: introduce fast memory
> registration mode (FRWR)" from Aug 28, 2013, leads to the following
> Smatch complaint:
>
> drivers/infiniband/ulp/isert/ib_isert.c:622 isert_connect_release()
> warn: variable dereferenced before check 'device' (see line 598)
>
> drivers/infiniband/ulp/isert/ib_isert.c
> 597 if (device->use_frwr)
> ^^^^^^^^^^^^^^^^
> Patch introduces dereference.
>
> 598 isert_conn_free_frwr_pool(isert_conn);
> 599
>
> [ snip ]
>
> 620 kfree(isert_conn);
> 621
> 622 if (device)
> ^^^^^^
> Existing check.
>
> 623 isert_device_try_release(device);
> 624
>
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-10-19 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 11:14 iser-target: introduce fast memory registration mode (FRWR) Dan Carpenter
[not found] ` <20130903111436.GA15230-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2013-10-19 8:29 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131019082910.GK5550@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox