From: Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
yevgenyp-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH for-next 7/9] mlx5: Support arbitrary page size to firmware
Date: Thu, 24 Oct 2013 11:06:12 +0300 [thread overview]
Message-ID: <20131024080612.GA18644@mtldesk30> (raw)
In-Reply-To: <CAG4TOxPfHR8h22E5reYSghNszzvHCUfQLMOH6mphNTc+QWc16Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Oct 24, 2013 at 12:57:47AM -0700, Roland Dreier wrote:
> On Tue, Oct 22, 2013 at 11:53 PM, Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:
> > This patch also fixes several places that referred to PAGE_SHIFT instead of
> > explicit 12 which is the inherent page shift on Connect-IB.
>
> Patch looks fine but maybe we should have a follow-up that changes
> this magic constant of 12 to something like MLX5_ADAPTER_PAGE_SHIFT
> (defined to 12 in a header somewhere)?
>
Yes it makes sense.
I am going to send a few more patches and will include one that fixes
the page shift thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-24 8:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 6:53 [PATCH for-next 0/9] Mellanox mlx5 driver updates for 3.13 Eli Cohen
[not found] ` <1382511201-7061-1-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-23 6:53 ` [PATCH for-next 1/9] IB/mlx5: Fix check of number of entries in create CQ Eli Cohen
2013-10-23 6:53 ` [PATCH for-next 2/9] IB/mlx5: Multithreaded create mr Eli Cohen
2013-10-23 6:53 ` [PATCH for-next 3/9] IB/mlx5: Fix overflow check in IB_WR_FAST_REG_MR Eli Cohen
2013-10-23 6:53 ` [PATCH for-next 4/9] IB/mlx5: Simplify mlx5_ib_destroy_srq Eli Cohen
2013-10-23 6:53 ` [PATCH for-next 5/9] IB/mlx5: Fix srq free in destroy qp Eli Cohen
2013-10-23 6:53 ` [PATCH for-next 6/9] mlx5: Fix cleanup flow when DMA mapping fails Eli Cohen
2013-10-23 6:53 ` [PATCH for-next 7/9] mlx5: Support arbitrary page size to firmware Eli Cohen
[not found] ` <1382511201-7061-8-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-24 7:57 ` Roland Dreier
[not found] ` <CAG4TOxPfHR8h22E5reYSghNszzvHCUfQLMOH6mphNTc+QWc16Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-24 8:06 ` Eli Cohen [this message]
2013-10-23 6:53 ` [PATCH for-next 8/9] mlx5: Clear reserved area in set_hca_cap Eli Cohen
2013-10-23 6:53 ` [PATCH for-next 9/9] mlx5_core: Change optimal_reclaimed_pages for better performance Eli Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024080612.GA18644@mtldesk30 \
--to=eli-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yevgenyp-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox