From: Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
Cc: roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH for-next 14/14] IB/mlx5: Remove old field for create mkey mailbox
Date: Wed, 15 Jan 2014 09:38:41 +0200 [thread overview]
Message-ID: <20140115073841.GC31664@mtldesk30> (raw)
In-Reply-To: <1389717437.1585.68.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On Tue, Jan 14, 2014 at 05:37:17PM +0100, Yann Droneaud wrote:
>
> Is it subject to change between various firmware revision ?
>
> If yes, it could of user interest to specify the base/current
> version of the applicable firmware.
The sizes never changed and this field was never used so I just
redefined it as reserved.
>
> > @@ -849,8 +849,8 @@ struct mlx5_create_mkey_mbox_in {
> > struct mlx5_mkey_seg seg;
> > u8 rsvd1[16];
> > __be32 xlat_oct_act_size;
> > - __be32 bsf_coto_act_size;
> > - u8 rsvd2[168];
> > + __be32 rsvd2;
>
> For a reserved field, I think we don't care of it being be or le.
>
Right, so be is just as good as le. The "be" is a sort of reminder
that driver/firmware interface is always big endian.
> > + u8 rsvd3[168];
> > __be64 pas[0];
> > };
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-01-15 7:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 15:45 [PATCH for-next 00/14] Patch set for 3.14 Eli Cohen
[not found] ` <1389714323-20130-1-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-01-14 15:45 ` [PATCH for-next 01/14] IB/mlx5: Remove unused coded in mr.c Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 02/14] mlx5_core: Remove dead code Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 03/14] IB/mlx5: Fix micro UAR allocator Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 04/14] net/mlx5_core: Fix out arg size in access_register command Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 05/14] IB/mlx5: Clear out struct before create QP command Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 06/14] net/mlx5_core: Use mlx5 core style warning Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 07/14] IB/mlx5: Make sure doorbell record is visible before doorbell Eli Cohen
[not found] ` <1389714323-20130-8-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-01-14 16:36 ` Yann Droneaud
[not found] ` <1389717393.1585.66.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-01-15 6:47 ` Eli Cohen
2014-01-15 10:19 ` Yann Droneaud
2014-01-14 15:45 ` [PATCH for-next 08/14] IB/mlx5: Implement modify CQ Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 09/14] IB/mlx5: Add support for resize CQ Eli Cohen
[not found] ` <1389714323-20130-10-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-01-14 16:36 ` Yann Droneaud
[not found] ` <1389717410.1585.67.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-01-15 7:33 ` Eli Cohen
2014-01-15 10:02 ` Yann Droneaud
[not found] ` <1389780175.572.10.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-01-15 11:24 ` Eli Cohen
2014-01-16 9:58 ` Yann Droneaud
2014-01-14 15:45 ` [PATCH for-next 10/14] net/mlx5_core: Improve debugfs readability Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 11/14] mlx5_core: Fix PowerPC support Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 12/14] IB/mlx5: Allow creation of QPs with zero length work queues Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 13/14] IB/mlx5: Abort driver cleanup if teardown hca fails Eli Cohen
2014-01-14 15:45 ` [PATCH for-next 14/14] IB/mlx5: Remove old field for create mkey mailbox Eli Cohen
[not found] ` <1389714323-20130-15-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-01-14 16:37 ` Yann Droneaud
[not found] ` <1389717437.1585.68.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-01-15 7:38 ` Eli Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115073841.GC31664@mtldesk30 \
--to=eli-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox