* [patch] IB/qib: cleanup qib_register_observer()
@ 2014-01-30 12:12 Dan Carpenter
[not found] ` <20140130121231.GA17753-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2014-02-24 18:54 ` Marciniszyn, Mike
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-01-30 12:12 UTC (permalink / raw)
To: Mike Marciniszyn
Cc: Roland Dreier, Sean Hefty, Hal Rosenstock, linux-rdma,
kernel-janitors
Returning directly is easier to read than do-nothing gotos. Remove the
duplicative check on "olp" and pulled the code in one indent level.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/infiniband/hw/qib/qib_diag.c b/drivers/infiniband/hw/qib/qib_diag.c
index 1686fd4bda87..52601ae4b327 100644
--- a/drivers/infiniband/hw/qib/qib_diag.c
+++ b/drivers/infiniband/hw/qib/qib_diag.c
@@ -689,28 +689,23 @@ int qib_register_observer(struct qib_devdata *dd,
const struct diag_observer *op)
{
struct diag_observer_list_elt *olp;
- int ret = -EINVAL;
+ unsigned long flags;
if (!dd || !op)
- goto bail;
- ret = -ENOMEM;
+ return -EINVAL;
olp = vmalloc(sizeof *olp);
if (!olp) {
pr_err("vmalloc for observer failed\n");
- goto bail;
+ return -ENOMEM;
}
- if (olp) {
- unsigned long flags;
- spin_lock_irqsave(&dd->qib_diag_trans_lock, flags);
- olp->op = op;
- olp->next = dd->diag_observer_list;
- dd->diag_observer_list = olp;
- spin_unlock_irqrestore(&dd->qib_diag_trans_lock, flags);
- ret = 0;
- }
-bail:
- return ret;
+ spin_lock_irqsave(&dd->qib_diag_trans_lock, flags);
+ olp->op = op;
+ olp->next = dd->diag_observer_list;
+ dd->diag_observer_list = olp;
+ spin_unlock_irqrestore(&dd->qib_diag_trans_lock, flags);
+
+ return 0;
}
/* Remove all registered observers when device is closed */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [patch] IB/qib: cleanup qib_register_observer()
[not found] ` <20140130121231.GA17753-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
@ 2014-02-19 20:46 ` Marciniszyn, Mike
0 siblings, 0 replies; 3+ messages in thread
From: Marciniszyn, Mike @ 2014-02-19 20:46 UTC (permalink / raw)
To: Dan Carpenter, infinipath
Cc: Roland Dreier, Hefty, Sean, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: [patch] IB/qib: cleanup qib_register_observer()
>
> Returning directly is easier to read than do-nothing gotos. Remove the
> duplicative check on "olp" and pulled the code in one indent level.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Acked-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [patch] IB/qib: cleanup qib_register_observer()
2014-01-30 12:12 [patch] IB/qib: cleanup qib_register_observer() Dan Carpenter
[not found] ` <20140130121231.GA17753-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
@ 2014-02-24 18:54 ` Marciniszyn, Mike
1 sibling, 0 replies; 3+ messages in thread
From: Marciniszyn, Mike @ 2014-02-24 18:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Roland Dreier, Hefty, Sean, Hal Rosenstock,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
> Subject: [patch] IB/qib: cleanup qib_register_observer()
>
> Returning directly is easier to read than do-nothing gotos. Remove the
> duplicative check on "olp" and pulled the code in one indent level.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the patch!
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-24 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-30 12:12 [patch] IB/qib: cleanup qib_register_observer() Dan Carpenter
[not found] ` <20140130121231.GA17753-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2014-02-19 20:46 ` Marciniszyn, Mike
2014-02-24 18:54 ` Marciniszyn, Mike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox