From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: parav.pandit-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter
Date: Fri, 7 Feb 2014 14:07:28 +0300 [thread overview]
Message-ID: <20140207110728.GA6470@elgon.mountain> (raw)
Hello Parav Pandit,
The patch fe2caefcdf58: "RDMA/ocrdma: Add driver for Emulex
OneConnect IBoE RDMA adapter" from Mar 21, 2012, leads to the
following static checker warning:
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1419 ocrdma_query_qp()
warn: right shifting to zero
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
1414 qp_attr->ah_attr.grh.sgid_index = qp->sgid_idx;
1415 qp_attr->ah_attr.grh.hop_limit = (params.hop_lmt_rq_psn &
1416 OCRDMA_QP_PARAMS_HOP_LMT_MASK) >>
1417 OCRDMA_QP_PARAMS_HOP_LMT_SHIFT;
1418 qp_attr->ah_attr.grh.traffic_class = (params.tclass_sq_psn &
1419 OCRDMA_QP_PARAMS_SQ_PSN_MASK) >>
1420 OCRDMA_QP_PARAMS_TCLASS_SHIFT;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
We always set traffic_class to zero. Maybe OCRDMA_QP_PARAMS_TCLASS_MASK
was intended instead of OCRDMA_QP_PARAMS_SQ_PSN_MASK?
Btw, the reason we are seing this bug is because the names are horrible.
Try reading the variable names out loud. OCRDMA_QP_PARAMS_SQ_PSN_MASK
is 6 words. It's 16 syllables long. It takes me about 4 seconds to
just pronounce it. The next one is almost identical except for one or
two characters in the middle. http://www.spotthedifference.com
Even though the variable names are longer than a Tolstoy novel, I still
have no idea what they mean. I know that the "T" in
OCRDMA_QP_PARAMS_TCLASS_SHIFT stands for "traffic" but when it comes to
the "SQ_PSN" then I have no idea about that.
1421
1422 qp_attr->ah_attr.ah_flags = IB_AH_GRH;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2014-02-07 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 11:07 Dan Carpenter [this message]
[not found] ` <20140207110728.GA6470-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2014-02-07 11:51 ` RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter Devesh Sharma
-- strict thread matches above, loose matches on Subject: below --
2015-02-26 12:30 Dan Carpenter
2015-02-26 17:54 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207110728.GA6470@elgon.mountain \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=parav.pandit-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox