From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Ammar Haj Hamad <ahamad-DMD6N21cJuFWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH] libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down
Date: Tue, 15 Apr 2014 09:43:16 -0700 [thread overview]
Message-ID: <20140415094316.f16055aaa70c239bd8fe7159@intel.com> (raw)
In-Reply-To: <0a2301cf41e2$3ebde380$bc39aa80$@asaltech.com>
Ammar,
This patch does not apply cleanly.
09:41:21 > git am ../\[PATCH\]__libibmad_src_dump.c___Set_the_vlaue_of__LinkWidthActive_to_undefined\(width\)_when_the_port_is_down.eml
Applying: libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down
fatal: patch fragment without header at line 18: @@ -171,6 +171,9 @@ void mad_dump_linkwidth(char *buf, int bufsz, void *val,
Patch failed at 0001 libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down
Also I don't think it showed up on linux-rdma.
Could you make sure to send as plain text. That could be why linux-rdma dropped it and I missed it.
Thanks,
Ira
On Mon, 17 Mar 2014 15:10:10 +0200
Ammar Haj Hamad <ahamad-DMD6N21cJuFWk0Htik3J/w@public.gmane.org> wrote:
> This patch is to set the vlaue of LinkWidthActive to undefined({width}) when
> the port is down
>
>
>
> Signed-off-by: Ammar Haj Hamad <ahamad-DMD6N21cJuFWk0Htik3J/w@public.gmane.org>
>
> ---
>
> src/dump.c | 3 +++
>
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>
>
> diff --git a/src/dump.c b/src/dump.c
>
> index f77d739..4bc8153 100644
>
> --- a/src/dump.c
>
> +++ b/src/dump.c
>
> @@ -171,6 +171,9 @@ void mad_dump_linkwidth(char *buf, int bufsz, void *val,
> int valsz)
>
> int width = *(int *)val;
>
> switch (width) {
>
> + case 0:
>
> + snprintf(buf , bufsz , "undefined (%d)",
> width);
>
> + break;
>
> case 1:
>
> snprintf(buf, bufsz, "1X");
>
> break;
>
> --
>
> 1.7.1
>
>
>
>
>
>
>
>
>
> _____
>
> Ammar Omar Haj Hamad | Software Engineer | ASAL technologies
> - Mellanox
>
> Mobile : +970599751673 | ahamad-DMD6N21cJuFWk0Htik3J/w@public.gmane.org | Skype :
> ammar.hajhamad.asal
>
>
>
--
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next parent reply other threads:[~2014-04-15 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0a2301cf41e2$3ebde380$bc39aa80$@asaltech.com>
2014-04-15 16:43 ` Ira Weiny [this message]
[not found] ` <20140415094316.f16055aaa70c239bd8fe7159-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-15 16:54 ` [PATCH] libibmad/src/dump.c : Set the vlaue of LinkWidthActive to undefined(width) when the port is down Hal Rosenstock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415094316.f16055aaa70c239bd8fe7159@intel.com \
--to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=ahamad-DMD6N21cJuFWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox