From: Shamir Rabinovith <shamir.rabinovitch-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] librdmacm: Fix verbs leak due to reentrancy issue
Date: Tue, 29 Apr 2014 16:48:04 +0300 [thread overview]
Message-ID: <20140429134803.GA11791@shamir-pc> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373992F2EE8-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Tue, Apr 22, 2014 at 06:35:45PM +0000, Hefty, Sean wrote:
> > I was out of work so I tested the patch "librdmacm: lazy initialization
> > for ib devices" today. The patch works fine for my test case. The only
> > concern I have is that I think the patch might leak verbs context. I
> > think that any call to ucma_init_device must be done with mutex locked.
> > Please correct me if I am wrong.
>
> I think you're correct; the lock needs to move up. I'll apply your fix. Thanks!
librdmacm git (git://git.openfabrics.org/~shefty/librdmacm.git)
currently only has the lazy initialization patch (23ffef0 librdmacm:
Support lazy initialization) but this patch is missing. can you please
add this fix to the git if you approve it? thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-29 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 11:22 [PATCH] librdmacm: Fix verbs leak due to reentrancy issue shamir rabinovitch
2014-04-22 18:35 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373992F2EE8-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-29 13:48 ` Shamir Rabinovith [this message]
2014-04-30 3:14 ` Hefty, Sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429134803.GA11791@shamir-pc \
--to=shamir.rabinovitch-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox