From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shamir Rabinovith Subject: Re: [PATCH] librdmacm: Fix verbs leak due to reentrancy issue Date: Tue, 29 Apr 2014 16:48:04 +0300 Message-ID: <20140429134803.GA11791@shamir-pc> References: <20140422112202.GA7440@shamir-pc> <1828884A29C6694DAF28B7E6B8A82373992F2EE8@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373992F2EE8-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, Apr 22, 2014 at 06:35:45PM +0000, Hefty, Sean wrote: > > I was out of work so I tested the patch "librdmacm: lazy initialization > > for ib devices" today. The patch works fine for my test case. The only > > concern I have is that I think the patch might leak verbs context. I > > think that any call to ucma_init_device must be done with mutex locked. > > Please correct me if I am wrong. > > I think you're correct; the lock needs to move up. I'll apply your fix. Thanks! librdmacm git (git://git.openfabrics.org/~shefty/librdmacm.git) currently only has the lazy initialization patch (23ffef0 librdmacm: Support lazy initialization) but this patch is missing. can you please add this fix to the git if you approve it? thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html