Re: [PATCH libibverbs V3 2/3] Use neighbour lookup for RoCE UD QPs Eth L2 resolution

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Thu, May 08, 2014 at 11:05:41PM +0300, Or Gerlitz wrote:

> Thanks for looking && commenting, Matan and myself will digest your
> feedback and respond/fix what's needed. BTW - note that this is V3
> where V0/1/2 were posted three months ago, where the earlier rounds of
> reviewers were focused on other portions of the series. So better late
> than never, review on the verbs extensions elements now happens :)

What changed is that Roland took the verbs extensions patches, so now
I am willing to spend time on proposed ABI changes :)

>From now on I think every proposed API/ABI change should be in an
isolated patch from anything else, it should be accompanied by other
patches showing the implementation, and the ABI patch specifically
should earn a public Reviewed-By from at least two of people who
designed this monster: Sean, Liran and myself.

Roland?

.. and you should start by correcting the flow steering changes, they
are not up to the standard and haven't earned the above reviews.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html