From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH libibverbs V3 2/3] Use neighbour lookup for RoCE UD QPs Eth L2 resolution Date: Thu, 8 May 2014 14:15:49 -0600 Message-ID: <20140508201549.GA32622@obsidianresearch.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz Cc: Or Gerlitz , Roland Dreier , linux-rdma , Matan Barak , Yishai Hadas , Doug Ledford , "Hefty, Sean" , Liran Liss List-Id: linux-rdma@vger.kernel.org On Thu, May 08, 2014 at 11:05:41PM +0300, Or Gerlitz wrote: > Thanks for looking && commenting, Matan and myself will digest your > feedback and respond/fix what's needed. BTW - note that this is V3 > where V0/1/2 were posted three months ago, where the earlier rounds of > reviewers were focused on other portions of the series. So better late > than never, review on the verbs extensions elements now happens :) What changed is that Roland took the verbs extensions patches, so now I am willing to spend time on proposed ABI changes :) >>From now on I think every proposed API/ABI change should be in an isolated patch from anything else, it should be accompanied by other patches showing the implementation, and the ABI patch specifically should earn a public Reviewed-By from at least two of people who designed this monster: Sean, Liran and myself. Roland? .. and you should start by correcting the flow steering changes, they are not up to the standard and haven't earned the above reviews. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html