From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH libibverbs V3 2/3] Use neighbour lookup for RoCE UD QPs Eth L2 resolution Date: Thu, 8 May 2014 14:46:38 -0600 Message-ID: <20140508204638.GA1197@obsidianresearch.com> References: <20140508201549.GA32622@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz Cc: Or Gerlitz , Roland Dreier , linux-rdma , Matan Barak , Yishai Hadas , Doug Ledford , "Hefty, Sean" , Liran Liss , Tzahi Oved List-Id: linux-rdma@vger.kernel.org On Thu, May 08, 2014 at 11:22:47PM +0300, Or Gerlitz wrote: > On Thu, May 8, 2014 at 11:15 PM, Jason Gunthorpe > wrote: > > On Thu, May 08, 2014 at 11:05:41PM +0300, Or Gerlitz wrote: > > > >> Thanks for looking && commenting, Matan and myself will digest your > >> feedback and respond/fix what's needed. BTW - note that this is V3 > >> where V0/1/2 were posted three months ago, where the earlier rounds of > >> reviewers were focused on other portions of the series. So better late > >> than never, review on the verbs extensions elements now happens :) > > > > What changed is that Roland took the verbs extensions patches, so now > > I am willing to spend time on proposed ABI changes :) > > > > From now on I think every proposed API/ABI change should be in an > > isolated patch from anything else, it should be accompanied by other > > patches showing the implementation, and the ABI patch specifically > > should earn a public Reviewed-By from at least two of people who > > designed this monster: Sean, Liran and myself. > > Did you mean Tzahi? Hmm, correct me if I'm wrong, but back in 2011 when this was designed it was Liran, Sean, and myself that mainly hashed out all the details on the list. I admit I'm not entirely sure who the actual patches came from, as they had Saen, Yishai and Tzahi named as authors. Anyhow, if Tzahi wrote the extension patches and understands all the discussion that underlies them then he should be on the list. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html