From: Jack Morgenstein <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
Cc: kbuild test robot
<fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
kbuild-all-JC7UmRfGjtg@public.gmane.org,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [infiniband:for-next 41/47] drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:2875:3: warning: case value '7' not in enumerated type 'enum qp_transition'
Date: Sun, 1 Jun 2014 10:25:52 +0300 [thread overview]
Message-ID: <20140601102552.7f5cda30@jpm-OptiPlex-GX620> (raw)
In-Reply-To: <CAL1RGDXoVByoFadRiH7iRxWj9AdShEJtvpoj_5uNhkudGrwJPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, 30 May 2014 15:43:39 -0700
Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org> wrote:
> Looks like this is actually a bug... assuming you guys agree the patch
> is correct, I'll add the following:
>
> commit 165cb465f73c (HEAD, mlx4)
> Author: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
> Date: Fri May 30 15:38:58 2014
>
> mlx4_core: Move handling of MLX4_QP_ST_MLX to proper switch
> statement
>
> The handling of MLX4_QP_ST_MLX in verify_qp_parameters() was
> accidentally put inside the inner switch statement (that handles
> which transition of RC/UC/XRC QPs is happening). Fix this by moving
> the case to the outer switch statement.
>
> The compiler pointed this out with:
>
> drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In
> function 'verify_qp_parameters':
> >> drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:2875:3:
> warning: case value '7' not in enumerated type 'enum qp_transition'
> [-Wswitch]
> case MLX4_QP_ST_MLX:
>
> Reported-by: kbuild test robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Fixes: 99ec41d0a48c ("mlx4: Add infrastructure for selecting VFs
> to enable QP0 via MLX proxy QPs")
> Signed-off-by: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
Acked-by: Jack Morgenstein <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
----
Thanks, Roland! your fix is exactly right!
-Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-06-01 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53882b5a.UAE9BgmHCPuDMdrw%fengguang.wu@intel.com>
[not found] ` <53882b5a.UAE9BgmHCPuDMdrw%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-05-30 22:43 ` [infiniband:for-next 41/47] drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:2875:3: warning: case value '7' not in enumerated type 'enum qp_transition' Roland Dreier
[not found] ` <CAL1RGDXoVByoFadRiH7iRxWj9AdShEJtvpoj_5uNhkudGrwJPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-01 7:25 ` Jack Morgenstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140601102552.7f5cda30@jpm-OptiPlex-GX620 \
--to=jackm-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kbuild-all-JC7UmRfGjtg@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox