From: "'J. Bruce Fields'" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: 'Devesh Sharma'
<Devesh.Sharma-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org>,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tom-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org
Subject: Re: [PATCH V3] svcrdma: refactor marshalling logic
Date: Mon, 2 Jun 2014 12:57:16 -0400 [thread overview]
Message-ID: <20140602165716.GB20031@fieldses.org> (raw)
In-Reply-To: <004901cf7e83$15107790$3f3166b0$@opengridcomputing.com>
On Mon, Jun 02, 2014 at 11:52:47AM -0500, Steve Wise wrote:
> > > You're correct. And this bug appears to be in the current upstream code as well. If
> an
> > > IB_WR_LOCAL_INV wr is used, it must include IB_SEND_FENCE to fence it until the prior
> > read
> > > completes.
> > >
> > > Good catch! I'll post V4 soon.
> >
> > Any chance that can be handled as a separate patch rather than folded
> > in?
> >
> > (Disclaimer: I've been following the discussion only very
> > superficially.)
> >
>
> Sure. I'll post the patch soon.
Thanks, and, again, I'm not terribly happy about the monster
patch--anything you can split off it is great, even if that thing's
small. As long as all the intermediate stages still build and run.
(And any bugs you've identified in upstream code are good candidates for
separate patches, hopefully preceding the rewrite. That also allows us
to apply those fixes to stable kernels if appropriate.)
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-02 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 16:55 [PATCH V3] svcrdma: refactor marshalling logic Steve Wise
[not found] ` <20140529165532.16349.95248.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2014-05-29 23:43 ` Chuck Lever
2014-05-30 5:29 ` Devesh Sharma
[not found] ` <EE7902D3F51F404C82415C4803930ACD3FE01265-DWYeeINJQrxExQ8dmkPuX0M9+F4ksjoh@public.gmane.org>
2014-05-30 13:02 ` Steve Wise
2014-05-31 3:34 ` Devesh Sharma
[not found] ` <EE7902D3F51F404C82415C4803930ACD3FE01355-DWYeeINJQrxExQ8dmkPuX0M9+F4ksjoh@public.gmane.org>
2014-06-02 16:47 ` Steve Wise
2014-06-02 16:51 ` J. Bruce Fields
[not found] ` <20140602165151.GA20031-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2014-06-02 16:52 ` Steve Wise
2014-06-02 16:57 ` 'J. Bruce Fields' [this message]
[not found] ` <20140602165716.GB20031-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2014-06-02 17:06 ` Steve Wise
2014-06-02 18:10 ` 'J. Bruce Fields'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602165716.GB20031@fieldses.org \
--to=bfields-uc3wqj2krung9huczpvpmw@public.gmane.org \
--cc=Devesh.Sharma-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
--cc=tom-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox