From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: jkosina-AlSwsSmVLrQ@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: IB/mlx4: Implement IB_QP_CREATE_USE_GFP_NOIO
Date: Mon, 9 Jun 2014 17:26:02 +0300 [thread overview]
Message-ID: <20140609142602.GA7095@mwanda> (raw)
Hello Jiri Kosina,
The patch 40f2287bd583: "IB/mlx4: Implement
IB_QP_CREATE_USE_GFP_NOIO" from May 11, 2014, leads to the following
static checker warning:
drivers/infiniband/hw/mlx4/qp.c:677 create_qp_common()
warn: use 'gfp' here instead of GFP_XXX?
drivers/infiniband/hw/mlx4/qp.c
673 if (!*caller_qp) {
674 if (qp_type == MLX4_IB_QPT_SMI || qp_type == MLX4_IB_QPT_GSI ||
675 (qp_type & (MLX4_IB_QPT_PROXY_SMI | MLX4_IB_QPT_PROXY_SMI_OWNER |
676 MLX4_IB_QPT_PROXY_GSI | MLX4_IB_QPT_TUN_SMI_OWNER))) {
677 sqp = kzalloc(sizeof (struct mlx4_ib_sqp), GFP_KERNEL);
^^^^^^^^^^
678 if (!sqp)
679 return -ENOMEM;
680 qp = &sqp->qp;
681 qp->pri.vid = 0xFFFF;
682 qp->alt.vid = 0xFFFF;
683 } else {
684 qp = kzalloc(sizeof (struct mlx4_ib_qp), GFP_KERNEL);
^^^^^^^^^^
685 if (!qp)
686 return -ENOMEM;
687 qp->pri.vid = 0xFFFF;
688 qp->alt.vid = 0xFFFF;
689 }
690 } else
691 qp = *caller_qp;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2014-06-09 14:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140609142602.GA7095@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox