From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH libibverbs V4 3/5] Use neighbour lookup for RoCE UD QPs Eth L2 resolution
Date: Thu, 12 Jun 2014 11:40:12 -0600 [thread overview]
Message-ID: <20140612174012.GA5244@obsidianresearch.com> (raw)
In-Reply-To: <5399A093.9070104-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Thu, Jun 12, 2014 at 03:44:03PM +0300, Matan Barak wrote:
> We could use a libibverbs API call in order to resolve the IP based
> GID into a MAC, but I think it could cause multiple vendors to have
> some code duplication.
If that is the only objection, I would prefer to see this techique. A
little provider code duplication is a lessor evil than introducing and
vetting new verbs APIs.
I think the patch will be very small and there will be very little to
talk about from an API perspective.
> We hope that in the future, more products will use RoCE with IP
> based GIDs. All those providers will have to supply similar code
> that checks if the link layer is Ethernet and IP based GID is used,
> they'll have to use the libibverbs utility function.
AFAIK all the other RoCEE implementations don't do InfiniBand link
layer, so their providers don't even need the test.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-12 17:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 9:38 [PATCH libibverbs V4 0/5] Add support for UD QPs under RoCE IP addressing Or Gerlitz
[not found] ` <1400405929-14313-1-git-send-email-ogerlitz-lZu6o6FoHf8DyJZ7l8Lk7nI+JuX82XLG@public.gmane.org>
2014-05-18 9:38 ` [PATCH libibverbs V4 1/5] Add ibv_port_cap_flags Or Gerlitz
[not found] ` <1400405929-14313-2-git-send-email-ogerlitz-lZu6o6FoHf8DyJZ7l8Lk7nI+JuX82XLG@public.gmane.org>
2014-05-20 6:41 ` Matan Barak
2014-05-18 9:38 ` [PATCH libibverbs V4 2/5] Extend create_ah in order to pass L2 parameters to the provider Or Gerlitz
[not found] ` <1400405929-14313-3-git-send-email-ogerlitz-lZu6o6FoHf8DyJZ7l8Lk7nI+JuX82XLG@public.gmane.org>
2014-05-21 19:55 ` Jason Gunthorpe
[not found] ` <20140521195549.GA26909-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2014-05-22 8:52 ` Matan Barak
[not found] ` <537DBAC3.9090008-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-06-11 10:54 ` Or Gerlitz
[not found] ` <53983580.1080002-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-06-11 15:05 ` Jason Gunthorpe
2014-05-18 9:38 ` [PATCH libibverbs V4 3/5] Use neighbour lookup for RoCE UD QPs Eth L2 resolution Or Gerlitz
[not found] ` <1400405929-14313-4-git-send-email-ogerlitz-lZu6o6FoHf8DyJZ7l8Lk7nI+JuX82XLG@public.gmane.org>
2014-05-21 20:31 ` Jason Gunthorpe
[not found] ` <20140521203107.GD26909-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2014-06-12 12:44 ` Matan Barak
[not found] ` <5399A093.9070104-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-06-12 17:40 ` Jason Gunthorpe [this message]
2014-05-18 9:38 ` [PATCH libibverbs V4 4/5] Add ibv_query_port_ex support Or Gerlitz
[not found] ` <1400405929-14313-5-git-send-email-ogerlitz-lZu6o6FoHf8DyJZ7l8Lk7nI+JuX82XLG@public.gmane.org>
2014-05-21 20:10 ` Jason Gunthorpe
[not found] ` <20140521201059.GC26909-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2014-05-22 9:07 ` Matan Barak
2014-05-18 9:38 ` [PATCH libibverbs V4 5/5] Optimize ibv_create_ah link query Or Gerlitz
2014-05-20 6:58 ` [PATCH libibverbs V4 0/5] Add support for UD QPs under RoCE IP addressing Or Gerlitz
[not found] ` <537AFD31.3000401-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-07-24 11:34 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140612174012.GA5244@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).