From: Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: mlx5: Add driver for Mellanox Connect-IB adapters
Date: Thu, 26 Jun 2014 13:37:43 +0300 [thread overview]
Message-ID: <20140626103743.GA12352@mtldesk30> (raw)
In-Reply-To: <20140620175832.GA11900@mwanda>
On Fri, Jun 20, 2014 at 08:58:32PM +0300, Dan Carpenter wrote:
> 976
> 977 err_create:
> 978 if (qp->create_type == MLX5_QP_USER)
> 979 destroy_qp_user(pd, qp);
> ^^^^^^^^^^^^^^^
> But we dereference it inside destroy_qp_user() unconditionally.
>
> 980 else if (qp->create_type == MLX5_QP_KERNEL)
> 981 destroy_qp_kernel(dev, qp);
>
When we get here we already updated create_type and since all
MLX5_QP_USER type QPs have PD the logic is not broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-26 10:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 17:58 mlx5: Add driver for Mellanox Connect-IB adapters Dan Carpenter
2014-06-26 10:37 ` Eli Cohen [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-07-10 10:55 Dan Carpenter
[not found] ` <20130710105538.GB31232-dZEljifmRObu9KfB+GxooP8+0UxHXcjY@public.gmane.org>
2013-07-15 14:29 ` Or Gerlitz
2013-07-15 15:18 ` Eli Cohen
2013-07-10 10:54 Dan Carpenter
[not found] ` <20130710105415.GA31232-dZEljifmRObu9KfB+GxooP8+0UxHXcjY@public.gmane.org>
2013-07-10 11:28 ` Or Gerlitz
2013-07-10 20:16 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626103743.GA12352@mtldesk30 \
--to=eli-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox