From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: bvanassche-HInyCGIudOg@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: IB/srp: Fix deadlock between host removal and multipathd
Date: Tue, 5 Aug 2014 02:31:40 +0300 [thread overview]
Message-ID: <20140804233140.GA9106@mwanda> (raw)
Hello Bart Van Assche,
The patch bcc059103591: "IB/srp: Fix deadlock between host removal
and multipathd" from Jul 9, 2014, leads to the following static
checker warning:
drivers/infiniband/ulp/srp/ib_srp.c:3323 srp_init_module()
warn: 'srp_remove_wq' isn't an ERR_PTR
drivers/infiniband/ulp/srp/ib_srp.c
3321
3322 srp_remove_wq = create_workqueue("srp_remove");
Returns NULL on failure and not an ERR_PTR.
3323 if (IS_ERR(srp_remove_wq)) {
3324 ret = PTR_ERR(srp_remove_wq);
3325 goto out;
3326 }
3327
3328 ret = -ENOMEM;
3329 ib_srp_transport_template =
3330 srp_attach_transport(&ib_srp_transport_functions);
3331 if (!ib_srp_transport_template)
3332 goto destroy_wq;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2014-08-04 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 23:31 Dan Carpenter [this message]
2014-08-06 8:28 ` IB/srp: Fix deadlock between host removal and multipathd Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804233140.GA9106@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox