Re: [PATCH libibverbs V5 0/2] Use neighbour lookup for RoCE UD QPs Eth L2 resolution

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Wed, Aug 20, 2014 at 09:49:39AM +0300, Matan Barak wrote:
> Hi Roland,
> 
> This series adds support for Ethernet L2 address resolution for RoCE UD QPs,
> whose L2 address-handles, unlike RC/UC/XRC/etc QPs are set from user space
> without going through uverbs and the kernel IB core. The code is also
> compatible both with old kernels that don't run IP based addressing.

I think this looks much better now, avoiding churning the public API
has made this much less risky..

I'm not sure Roland's feeling on the subject, but I would like to see
your code be more consistent with the rest of verbs:
 - No 'reversed equal' ie verbs doesn't do: 'NULL == foo'
 - Pointless '^' equality 'optimization'
 - Wouldn't hurt to fix the various checkpatch warnings (for the most
   part verbs is in the style of Linux)
 - System libraries should not be randomly printing things in error
   cases. Use errno properly.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html