Re: [PATCH] ib_ipoib: CSUM support in connected mode

[Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

On Sun, Oct 05, 2014 at 04:35:00PM -0600, Jason Gunthorpe wrote:
> On Sat, Oct 04, 2014 at 04:45:47AM -0700, Yuval Shaia wrote:
> 
> > +	if (cm_ibcrc_as_csum)
> > +		skb->ip_summed = CHECKSUM_UNNECESSARY;
> > +
> 
> As I said before, I think this scheme should be using CHECKSUM_PARTIAL
> so packets can be forwarded correctly.
> 
>  *      PARTIAL: identical to the case for output below.  This may occur
>  *          on a packet received directly from another Linux OS, e.g.,
>  *          a virtualised Linux kernel on the same host.  The packet can
>  *          be treated in the same way as UNNECESSARY except that on
>  *          output (i.e., forwarding) the checksum must be filled in
>  *          by the OS or the hardware.
> 
> Which is exactly what we want.
Will do, thanks.
This is in case this code runs on bridge, right?
> 
> Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html