From: Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: mlx5_core: Fix PowerPC support
Date: Sun, 19 Oct 2014 11:09:28 +0300 [thread overview]
Message-ID: <20141019080928.GF31103@mtldesk30> (raw)
In-Reply-To: <20141016110852.GA16271@mwanda>
On Thu, Oct 16, 2014 at 02:08:52PM +0300, Dan Carpenter wrote:
> Hello Eli Cohen,
>
> The patch 05bdb2ab6b09: "mlx5_core: Fix PowerPC support" from Jan 14,
> 2014, leads to the following static checker warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c:225 free_4k()
> warn: right shifting to zero
>
> drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
> 214 static void free_4k(struct mlx5_core_dev *dev, u64 addr)
> 215 {
> 216 struct fw_page *fwp;
> 217 int n;
> 218
> 219 fwp = find_fw_page(dev, addr & PAGE_MASK);
> 220 if (!fwp) {
> 221 mlx5_core_warn(dev, "page not found\n");
> 222 return;
> 223 }
> 224
> 225 n = (addr & ~PAGE_MASK) >> MLX5_ADAPTER_PAGE_SHIFT;
>
> Maybe n = addr >> MLX5_ADAPTER_PAGE_SHIFT; was intended? (Totally
> random guess).
>
No, I need to find the index of the 4K fragment within the system page
(64K in the case of PPC) so I need to mask out the higher bits. I
assume you are seeing this when building on x86. When the system page
size is 4K then n will always equal zero but in the case of larger
page sizes (e.g. ppc), n could have non-zero values.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-19 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 11:08 mlx5_core: Fix PowerPC support Dan Carpenter
2014-10-19 8:09 ` Eli Cohen [this message]
2014-10-20 15:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019080928.GF31103@mtldesk30 \
--to=eli-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox