From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH libibverbs] Add MR re-registeration Date: Sun, 2 Nov 2014 19:50:49 -0700 Message-ID: <20141103025049.GA31929@obsidianresearch.com> References: <1414920605-18943-1-git-send-email-ogerlitz@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1414920605-18943-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz Cc: Roland Dreier , Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Yishai Hadas , Matan Barak List-Id: linux-rdma@vger.kernel.org On Sun, Nov 02, 2014 at 11:30:05AM +0200, Or Gerlitz wrote: > @@ -886,7 +887,7 @@ struct ibv_context_ops { > int (*dealloc_pd)(struct ibv_pd *pd); > struct ibv_mr * (*reg_mr)(struct ibv_pd *pd, void *addr, size_t length, > int access); > - struct ibv_mr * (*rereg_mr)(struct ibv_mr *mr, > + int (*rereg_mr)(struct ibv_mr *mr, > int flags, > struct ibv_pd *pd, void *addr, > size_t length, What is going on here? Signatures in the ops structure should not be changed without quite a bit more explanation. I'd like to see this in a dedicated patch with a proper discussion about why it is safe... (I admit, I'm confused how this patch is adding rereg_mr when it already sort of seems to exist) Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html