[PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

[PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

[Yuval Shaia]

Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 drivers/net/ethernet/mellanox/mlx4/main.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index 7920f5f..e3fd50a 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -567,15 +567,14 @@ int mlx4_check_port_params(struct mlx4_dev *dev,
 {
 	int i;
 
-	for (i = 0; i < dev->caps.num_ports - 1; i++) {
-		if (port_type[i] != port_type[i + 1]) {
-			if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP)) {
+	if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP))
+		for (i = 0; i < dev->caps.num_ports - 1; i++) {
+			if (port_type[i] != port_type[i + 1]) {
 				mlx4_err(dev, "Only same port types supported "
 					 "on this HCA, aborting.\n");
 				return -EINVAL;
 			}
 		}
-	}
 
 	for (i = 0; i < dev->caps.num_ports; i++) {
 		if (!(port_type[i] & dev->caps.supported_type[i+1])) {
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

[Roland Dreier]

On Sat, Dec 6, 2014 at 10:46 AM, Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
>
> -       for (i = 0; i < dev->caps.num_ports - 1; i++) {
> -               if (port_type[i] != port_type[i + 1]) {
> -                       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP)) {
> +       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP))
> +               for (i = 0; i < dev->caps.num_ports - 1; i++) {
> +                       if (port_type[i] != port_type[i + 1]) {

I'm struggling to understand what this patch does.  It sure looks like
a NOP to me.

At least you need to resend it with a changelog that explains why we
want this change.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

[Yuval Shaia]

On Sun, Dec 07, 2014 at 09:24:26PM -0800, Roland Dreier wrote:
> On Sat, Dec 6, 2014 at 10:46 AM, Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> >
> > -       for (i = 0; i < dev->caps.num_ports - 1; i++) {
> > -               if (port_type[i] != port_type[i + 1]) {
> > -                       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP)) {
> > +       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP))
> > +               for (i = 0; i < dev->caps.num_ports - 1; i++) {
> > +                       if (port_type[i] != port_type[i + 1]) {
> 
> I'm struggling to understand what this patch does.  It sure looks like
> a NOP to me.
Move check out of the loop just to make the code more nice & readable.
> 
> At least you need to resend it with a changelog that explains why we
> want this change.
Will do.
> 
>  - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

[Yuval Shaia]

This patch is merely makes code more nice and readable.
Instead of checking for DPDP on every loop cycle the check moves out of the loop.

Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 drivers/net/ethernet/mellanox/mlx4/main.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index 861035f..ec4e3fd 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -567,15 +567,14 @@ int mlx4_check_port_params(struct mlx4_dev *dev,
 {
 	int i;
 
-	for (i = 0; i < dev->caps.num_ports - 1; i++) {
-		if (port_type[i] != port_type[i + 1]) {
-			if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP)) {
+	if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP))
+		for (i = 0; i < dev->caps.num_ports - 1; i++) {
+			if (port_type[i] != port_type[i + 1]) {
 				mlx4_err(dev, "Only same port types supported "
 					 "on this HCA, aborting.\n");
 				return -EINVAL;
 			}
 		}
-	}
 
 	for (i = 0; i < dev->caps.num_ports; i++) {
 		if (!(port_type[i] & dev->caps.supported_type[i+1])) {
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

[Or Gerlitz]

On Sun, Dec 7, 2014 at 7:05 PM, Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> This patch is merely makes code more nice and readable.
> Instead of checking for DPDP on every loop cycle the check moves out of the loop.

Few short comments:

1. avoid saying "this patch does this and that" in the change-log

2. change the patch subject line to reflect what the patch is doing

3. s/is merely makes/is merely making/



>
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/net/ethernet/mellanox/mlx4/main.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index 861035f..ec4e3fd 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -567,15 +567,14 @@ int mlx4_check_port_params(struct mlx4_dev *dev,
>  {
>         int i;
>
> -       for (i = 0; i < dev->caps.num_ports - 1; i++) {
> -               if (port_type[i] != port_type[i + 1]) {
> -                       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP)) {
> +       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP))
> +               for (i = 0; i < dev->caps.num_ports - 1; i++) {
> +                       if (port_type[i] != port_type[i + 1]) {
>                                 mlx4_err(dev, "Only same port types supported "
>                                          "on this HCA, aborting.\n");
>                                 return -EINVAL;
>                         }
>                 }
> -       }
>
>         for (i = 0; i < dev->caps.num_ports; i++) {
>                 if (!(port_type[i] & dev->caps.supported_type[i+1])) {
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

[Yuval Shaia]

On Tue, Dec 09, 2014 at 07:47:27PM +0200, Or Gerlitz wrote:
> On Sun, Dec 7, 2014 at 7:05 PM, Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> > This patch is merely makes code more nice and readable.
> > Instead of checking for DPDP on every loop cycle the check moves out of the loop.
> 
> Few short comments:
> 
> 1. avoid saying "this patch does this and that" in the change-log
> 
> 2. change the patch subject line to reflect what the patch is doing
> 
> 3. s/is merely makes/is merely making/
> 
How about something like:
"The check for DPDP moves out of the loop to make the code more correct and readable"
> 
> 
> >
> > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> >  drivers/net/ethernet/mellanox/mlx4/main.c |    7 +++----
> >  1 files changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> > index 861035f..ec4e3fd 100644
> > --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> > +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> > @@ -567,15 +567,14 @@ int mlx4_check_port_params(struct mlx4_dev *dev,
> >  {
> >         int i;
> >
> > -       for (i = 0; i < dev->caps.num_ports - 1; i++) {
> > -               if (port_type[i] != port_type[i + 1]) {
> > -                       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP)) {
> > +       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP))
> > +               for (i = 0; i < dev->caps.num_ports - 1; i++) {
> > +                       if (port_type[i] != port_type[i + 1]) {
> >                                 mlx4_err(dev, "Only same port types supported "
> >                                          "on this HCA, aborting.\n");
> >                                 return -EINVAL;
> >                         }
> >                 }
> > -       }
> >
> >         for (i = 0; i < dev->caps.num_ports; i++) {
> >                 if (!(port_type[i] & dev->caps.supported_type[i+1])) {
> > --
> > 1.7.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

[Yuval Shaia]

On Tue, Dec 09, 2014 at 07:47:27PM +0200, Or Gerlitz wrote:
> On Sun, Dec 7, 2014 at 7:05 PM, Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> > This patch is merely makes code more nice and readable.
> > Instead of checking for DPDP on every loop cycle the check moves out of the loop.
> 
> Few short comments:
> 
> 1. avoid saying "this patch does this and that" in the change-log
> 
> 2. change the patch subject line to reflect what the patch is doing
How about this:
"Check DPDP violation only when DPDP is not supported"
> 
> 3. s/is merely makes/is merely making/
> 
> 
> 
> >
> > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> >  drivers/net/ethernet/mellanox/mlx4/main.c |    7 +++----
> >  1 files changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> > index 861035f..ec4e3fd 100644
> > --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> > +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> > @@ -567,15 +567,14 @@ int mlx4_check_port_params(struct mlx4_dev *dev,
> >  {
> >         int i;
> >
> > -       for (i = 0; i < dev->caps.num_ports - 1; i++) {
> > -               if (port_type[i] != port_type[i + 1]) {
> > -                       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP)) {
> > +       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP))
> > +               for (i = 0; i < dev->caps.num_ports - 1; i++) {
> > +                       if (port_type[i] != port_type[i + 1]) {
> >                                 mlx4_err(dev, "Only same port types supported "
> >                                          "on this HCA, aborting.\n");
> >                                 return -EINVAL;
> >                         }
> >                 }
> > -       }
> >
> >         for (i = 0; i < dev->caps.num_ports; i++) {
> >                 if (!(port_type[i] & dev->caps.supported_type[i+1])) {
> > --
> > 1.7.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

[Matan Barak]

On 12/7/2014 7:05 PM, Yuval Shaia wrote:
> This patch is merely makes code more nice and readable.
> Instead of checking for DPDP on every loop cycle the check moves out of the loop.
>
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
>   drivers/net/ethernet/mellanox/mlx4/main.c |    7 +++----
>   1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index 861035f..ec4e3fd 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -567,15 +567,14 @@ int mlx4_check_port_params(struct mlx4_dev *dev,
>   {
>          int i;
>
> -       for (i =; i < dev->caps.num_ports - 1; i++) {
> -               if (port_type[i] !=ort_type[i + 1]) {
> -                       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP)) {
> +       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP))
> +               for (i =; i < dev->caps.num_ports - 1; i++) {
> +                       if (port_type[i] !=ort_type[i + 1]) {
>                                  mlx4_err(dev, "Only same port types supported "
>                                           "on this HCA, aborting.\n");
>                                  return -EINVAL;
>                          }
>                  }
> -       }
>
>          for (i =; i < dev->caps.num_ports; i++) {
>                  if (!(port_type[i] & dev->caps.supported_type[i+1])) {
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Hi,

Thanks for the patch. Could you please just fix the commit message?

Regards,
Matan
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

[Yuval Shaia]

On Wed, Dec 10, 2014 at 12:13:51PM +0200, Matan Barak wrote:
> 
> 
> On 12/7/2014 7:05 PM, Yuval Shaia wrote:
> >This patch is merely makes code more nice and readable.
> >Instead of checking for DPDP on every loop cycle the check moves out of the loop.
> >
> >Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> >---
> >  drivers/net/ethernet/mellanox/mlx4/main.c |    7 +++----
> >  1 files changed, 3 insertions(+), 4 deletions(-)
> >
> >diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> >index 861035f..ec4e3fd 100644
> >--- a/drivers/net/ethernet/mellanox/mlx4/main.c
> >+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> >@@ -567,15 +567,14 @@ int mlx4_check_port_params(struct mlx4_dev *dev,
> >  {
> >         int i;
> >
> >-       for (i =; i < dev->caps.num_ports - 1; i++) {
> >-               if (port_type[i] !=ort_type[i + 1]) {
> >-                       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP)) {
> >+       if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP))
> >+               for (i =; i < dev->caps.num_ports - 1; i++) {
> >+                       if (port_type[i] !=ort_type[i + 1]) {
> >                                 mlx4_err(dev, "Only same port types supported "
> >                                          "on this HCA, aborting.\n");
> >                                 return -EINVAL;
> >                         }
> >                 }
> >-       }
> >
> >         for (i =; i < dev->caps.num_ports; i++) {
> >                 if (!(port_type[i] & dev->caps.supported_type[i+1])) {
> >--
> >1.7.1
> >
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> >the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> 
> Hi,
> 
> Thanks for the patch. Could you please just fix the commit message?
Commit message has been changed.
New patch sent, please review.
This thread is close.
> 
> Regards,
> Matan
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html