[PATCH next] RDMA/ocrdma: ocrdma_sysfs_rcv_pkts() can be static

[PATCH next] RDMA/ocrdma: ocrdma_sysfs_rcv_pkts() can be static

[kbuild test robot]

drivers/infiniband/hw/ocrdma/ocrdma_stats.c:253:5: sparse: symbol 'ocrdma_sysfs_rcv_pkts' was not declared. Should it be static?
drivers/infiniband/hw/ocrdma/ocrdma_stats.c:264:5: sparse: symbol 'ocrdma_sysfs_rcv_data' was not declared. Should it be static?
drivers/infiniband/hw/ocrdma/ocrdma_stats.c:317:5: sparse: symbol 'ocrdma_sysfs_xmit_pkts' was not declared. Should it be static?
drivers/infiniband/hw/ocrdma/ocrdma_stats.c:332:5: sparse: symbol 'ocrdma_sysfs_xmit_data' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 ocrdma_stats.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
index 9d1701f..614d1a8 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
@@ -250,7 +250,7 @@ static char *ocrdma_rx_stats(struct ocrdma_dev *dev)
 	return stats;
 }
 
-u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va;
@@ -261,7 +261,7 @@ u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev)
 		+ (u64)rx_stats->roce_frame_payload_len_drops;
 }
 
-u64 ocrdma_sysfs_rcv_data(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_rcv_data(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va;
@@ -314,7 +314,7 @@ static char *ocrdma_tx_stats(struct ocrdma_dev *dev)
 	return stats;
 }
 
-u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va;
@@ -329,7 +329,7 @@ u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev)
 	convert_to_64bit(tx_stats->ack_pkts_lo, tx_stats->ack_pkts_hi));
 }
 
-u64 ocrdma_sysfs_xmit_data(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_xmit_data(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[next:master 10113/10230] drivers/infiniband/hw/ocrdma/ocrdma_stats.c:253:5: sparse: symbol 'ocrdma_sysfs_rcv_pkts' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   c26de6d26435059245babb016acb840d9e0e5d12
commit: 8b528884f901757fb21c5900151fc294344d78f6 [10113/10230] RDMA/ocrdma: Add support for IB stack compliant stats in sysfs.
reproduce:
  # apt-get install sparse
  git checkout 8b528884f901757fb21c5900151fc294344d78f6
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/infiniband/hw/ocrdma/ocrdma_stats.c:253:5: sparse: symbol 'ocrdma_sysfs_rcv_pkts' was not declared. Should it be static?
>> drivers/infiniband/hw/ocrdma/ocrdma_stats.c:264:5: sparse: symbol 'ocrdma_sysfs_rcv_data' was not declared. Should it be static?
>> drivers/infiniband/hw/ocrdma/ocrdma_stats.c:317:5: sparse: symbol 'ocrdma_sysfs_xmit_pkts' was not declared. Should it be static?
>> drivers/infiniband/hw/ocrdma/ocrdma_stats.c:332:5: sparse: symbol 'ocrdma_sysfs_xmit_data' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

RE: [PATCH next] RDMA/ocrdma: ocrdma_sysfs_rcv_pkts() can be static

[Mitesh Ahuja]

Acked-by: Mitesh Ahuja.

-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu@intel.com] 
Sent: Wednesday, February 18, 2015 9:16 AM
To: Mitesh Ahuja
Cc: kbuild-all@01.org; Roland Dreier; Devesh Sharma; Selvin Xavier; Sean Hefty; Hal Rosenstock; Duan Jiong; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH next] RDMA/ocrdma: ocrdma_sysfs_rcv_pkts() can be static

drivers/infiniband/hw/ocrdma/ocrdma_stats.c:253:5: sparse: symbol 'ocrdma_sysfs_rcv_pkts' was not declared. Should it be static?
drivers/infiniband/hw/ocrdma/ocrdma_stats.c:264:5: sparse: symbol 'ocrdma_sysfs_rcv_data' was not declared. Should it be static?
drivers/infiniband/hw/ocrdma/ocrdma_stats.c:317:5: sparse: symbol 'ocrdma_sysfs_xmit_pkts' was not declared. Should it be static?
drivers/infiniband/hw/ocrdma/ocrdma_stats.c:332:5: sparse: symbol 'ocrdma_sysfs_xmit_data' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 ocrdma_stats.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
index 9d1701f..614d1a8 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
@@ -250,7 +250,7 @@ static char *ocrdma_rx_stats(struct ocrdma_dev *dev)
 	return stats;
 }
 
-u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va; @@ -261,7 +261,7 @@ u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev)
 		+ (u64)rx_stats->roce_frame_payload_len_drops;
 }
 
-u64 ocrdma_sysfs_rcv_data(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_rcv_data(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va; @@ -314,7 +314,7 @@ static char *ocrdma_tx_stats(struct ocrdma_dev *dev)
 	return stats;
 }
 
-u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va; @@ -329,7 +329,7 @@ u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev)
 	convert_to_64bit(tx_stats->ack_pkts_lo, tx_stats->ack_pkts_hi));  }
 
-u64 ocrdma_sysfs_xmit_data(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_xmit_data(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va;

RE: [PATCH next] RDMA/ocrdma: ocrdma_sysfs_rcv_pkts() can be static

[Mitesh Ahuja]

Acked-by: Mitesh Ahuja <mitesh.ahuja-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>

-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org] 
Sent: Wednesday, February 18, 2015 9:16 AM
To: Mitesh Ahuja
Cc: kbuild-all-JC7UmRfGjtg@public.gmane.org; Roland Dreier; Devesh Sharma; Selvin Xavier; Sean Hefty; Hal Rosenstock; Duan Jiong; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH next] RDMA/ocrdma: ocrdma_sysfs_rcv_pkts() can be static

drivers/infiniband/hw/ocrdma/ocrdma_stats.c:253:5: sparse: symbol 'ocrdma_sysfs_rcv_pkts' was not declared. Should it be static?
drivers/infiniband/hw/ocrdma/ocrdma_stats.c:264:5: sparse: symbol 'ocrdma_sysfs_rcv_data' was not declared. Should it be static?
drivers/infiniband/hw/ocrdma/ocrdma_stats.c:317:5: sparse: symbol 'ocrdma_sysfs_xmit_pkts' was not declared. Should it be static?
drivers/infiniband/hw/ocrdma/ocrdma_stats.c:332:5: sparse: symbol 'ocrdma_sysfs_xmit_data' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 ocrdma_stats.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
index 9d1701f..614d1a8 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
@@ -250,7 +250,7 @@ static char *ocrdma_rx_stats(struct ocrdma_dev *dev)
 	return stats;
 }
 
-u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va; @@ -261,7 +261,7 @@ u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev)
 		+ (u64)rx_stats->roce_frame_payload_len_drops;
 }
 
-u64 ocrdma_sysfs_rcv_data(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_rcv_data(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va; @@ -314,7 +314,7 @@ static char *ocrdma_tx_stats(struct ocrdma_dev *dev)
 	return stats;
 }
 
-u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va; @@ -329,7 +329,7 @@ u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev)
 	convert_to_64bit(tx_stats->ack_pkts_lo, tx_stats->ack_pkts_hi));  }
 
-u64 ocrdma_sysfs_xmit_data(struct ocrdma_dev *dev)
+static u64 ocrdma_sysfs_xmit_data(struct ocrdma_dev *dev)
 {
 	struct ocrdma_rdma_stats_resp *rdma_stats =
 		(struct ocrdma_rdma_stats_resp *)dev->stats_mem.va;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html