* [next:master 10115/10230] drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?
@ 2015-02-18 3:49 kbuild test robot
2015-02-18 3:49 ` [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static kbuild test robot
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2015-02-18 3:49 UTC (permalink / raw)
To: Mitesh Ahuja
Cc: kbuild-all, Roland Dreier, Devesh Sharma, Selvin Xavier,
Sean Hefty, Hal Rosenstock, Jes Sorensen, Prarit Bhargava,
linux-rdma, linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: c26de6d26435059245babb016acb840d9e0e5d12
commit: 72278f474221abd5c09af5d3a4dff39f9d10948f [10115/10230] RDMA/ocrdma: Move PD resource management to driver.
reproduce:
# apt-get install sparse
git checkout 72278f474221abd5c09af5d3a4dff39f9d10948f
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
drivers/infiniband/hw/ocrdma/ocrdma_hw.c:109:15: sparse: cast to restricted __le32
>> drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?
drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1594:34: sparse: cast from restricted __le32
drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1595:34: sparse: cast from restricted __le32
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static
2015-02-18 3:49 [next:master 10115/10230] drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static? kbuild test robot
@ 2015-02-18 3:49 ` kbuild test robot
2015-02-18 11:30 ` Mitesh Ahuja
2015-02-18 11:35 ` Mitesh Ahuja
0 siblings, 2 replies; 4+ messages in thread
From: kbuild test robot @ 2015-02-18 3:49 UTC (permalink / raw)
To: Mitesh Ahuja
Cc: kbuild-all, Roland Dreier, Devesh Sharma, Selvin Xavier,
Sean Hefty, Hal Rosenstock, Jes Sorensen, Prarit Bhargava,
linux-rdma, linux-kernel
drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
ocrdma_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index ec4571b..037893a 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1507,7 +1507,7 @@ void ocrdma_alloc_pd_pool(struct ocrdma_dev *dev)
}
}
-void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
+static void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
{
ocrdma_mbx_dealloc_pd_range(dev);
kfree(dev->pd_mgr->pd_norm_bitmap);
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static
2015-02-18 3:49 ` [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static kbuild test robot
@ 2015-02-18 11:30 ` Mitesh Ahuja
2015-02-18 11:35 ` Mitesh Ahuja
1 sibling, 0 replies; 4+ messages in thread
From: Mitesh Ahuja @ 2015-02-18 11:30 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all-JC7UmRfGjtg@public.gmane.org, Roland Dreier,
Devesh Sharma, Selvin Xavier, Sean Hefty, Hal Rosenstock,
Jes Sorensen, Prarit Bhargava,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Acked-by: Mitesh Ahuja.
-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org]
Sent: Wednesday, February 18, 2015 9:20 AM
To: Mitesh Ahuja
Cc: kbuild-all-JC7UmRfGjtg@public.gmane.org; Roland Dreier; Devesh Sharma; Selvin Xavier; Sean Hefty; Hal Rosenstock; Jes Sorensen; Prarit Bhargava; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static
drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?
Signed-off-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
ocrdma_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index ec4571b..037893a 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1507,7 +1507,7 @@ void ocrdma_alloc_pd_pool(struct ocrdma_dev *dev)
}
}
-void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
+static void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
{
ocrdma_mbx_dealloc_pd_range(dev);
kfree(dev->pd_mgr->pd_norm_bitmap);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static
2015-02-18 3:49 ` [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static kbuild test robot
2015-02-18 11:30 ` Mitesh Ahuja
@ 2015-02-18 11:35 ` Mitesh Ahuja
1 sibling, 0 replies; 4+ messages in thread
From: Mitesh Ahuja @ 2015-02-18 11:35 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all@01.org, Roland Dreier, Devesh Sharma, Selvin Xavier,
Sean Hefty, Hal Rosenstock, Jes Sorensen, Prarit Bhargava,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Acked-by: Mitesh Ahuja <mitesh.ahuja@emulex.com>
-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu@intel.com]
Sent: Wednesday, February 18, 2015 9:20 AM
To: Mitesh Ahuja
Cc: kbuild-all@01.org; Roland Dreier; Devesh Sharma; Selvin Xavier; Sean Hefty; Hal Rosenstock; Jes Sorensen; Prarit Bhargava; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static
drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
ocrdma_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index ec4571b..037893a 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1507,7 +1507,7 @@ void ocrdma_alloc_pd_pool(struct ocrdma_dev *dev)
}
}
-void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
+static void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
{
ocrdma_mbx_dealloc_pd_range(dev);
kfree(dev->pd_mgr->pd_norm_bitmap);
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-18 11:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-18 3:49 [next:master 10115/10230] drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static? kbuild test robot
2015-02-18 3:49 ` [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static kbuild test robot
2015-02-18 11:30 ` Mitesh Ahuja
2015-02-18 11:35 ` Mitesh Ahuja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox