Re: [PATCH 0/9] IB/ipoib: fixup multicast locking issues

["ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Sun, Mar 15, 2015 at 11:52:44AM -0700, Doug Ledford wrote:
> 
> > On Mar 13, 2015, at 1:41 AM, Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > 
> > On Sun, Feb 22, 2015 at 2:26 AM, Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> >> This is the re-ordered, squashed version of my 22 patch set that I
> >> posted on Feb 11.  There are a few minor differences between that
> >> set and this one.  They are:
> > [...]
> > 
> > Doug, you wrote here a very detailed listing of the changes from
> > earlier posts and the testing the patches went through, which is
> > excellent. It would be very good if you can also post few liner
> > telling the changes done by the series in high level, so we can have
> > this test as part of a "merge" commit that says in the kernel logs.
> 
> OK.  I would take what I had in the original message and expand upon it then:
> 
> This entire patchset was intended to address the issue of ipoib
> interfaces being brought up/down in a tight loop, which will hardlock
> a standard v3.19 kernel.  It succeeds at resolving that problem.


I pulled this series and did some medium weight testing on 3.19 (module
reloads, insmod/rmmod, opensm restarts (client re-register)).  IPoIB recovered
without issue on each of the tests.

Tested-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

> 
> In order to accomplish this goal, it reworks how the IPOIB_MCAST_FLAG_BUSY flag is used.  Conceptually, that flag used to be set when we started a multicast join, and would stay set once the join was complete.  This left no way to tell if the multicast join was complete or still in flight.  This allowed race conditions to develop between joining multicast groups and taking an interface down.  A previous attempt to resolve these race conditions used the flag IPOIB_MCAST_JOIN_STARTED, but did not succeed at fully resolving the race conditions.  This patchset resolves this issue, plus a number of related issues discovered while working on this issue.  The primary fix itself is patch 6/9 and a more complete description of the changes to how the IPOIB_MCAST_FLAG_BUSY flag is now used can be found in that commit log.
> 
> —
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> 	GPG Key ID: 0E572FDD
> 
> 
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html