Re: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

["ira.weiny" <ira.weiny@intel.com>]

On Mon, Apr 20, 2015 at 10:28:57AM +0200, Michael Wang wrote:
> 
> Since v4:
>   * Thanks for the comments from Hal, Sean, Tom, Or Gerlitz, Jason,
>     Roland, Ira and Steve :-) Please remind me if anything missed :-P
>   * Fix logical issue inside 3#, 14#
>   * Refine 3#, 4#, 5# with label 'free'
>   * Rework 10# to stop using port 1 when port already assigned
> 
> There are plenty of lengthy code to check the transport type of IB device,
> or the link layer type of it's port, but actually we are just speculating
> whether a particular management/feature is supported by the device/port.
> 
> Thus instead of inferring, we should have our own mechanism for IB management
> capability/protocol/feature checking, several proposals below.
> 
> This patch set will reform the method of getting transport type, we will
> now using query_transport() instead of inferring from transport and link
> layer respectively, also we defined the new transport type to make the
> concept more reasonable.
> 
> Mapping List:
> 		node-type	link-layer	old-transport	new-transport
> nes		RNIC		ETH		IWARP		IWARP
> amso1100	RNIC		ETH		IWARP		IWARP
> cxgb3   	RNIC		ETH		IWARP		IWARP
> cxgb4   	RNIC		ETH		IWARP		IWARP
> usnic   	USNIC_UDP	ETH		USNIC_UDP	USNIC_UDP
> ocrdma  	IB_CA		ETH		IB		IBOE
> mlx4    	IB_CA		IB/ETH		IB		IB/IBOE
> mlx5    	IB_CA		IB		IB		IB
> ehca    	IB_CA		IB		IB		IB
> ipath   	IB_CA		IB		IB		IB
> mthca   	IB_CA		IB		IB		IB
> qib     	IB_CA		IB		IB		IB
> 
> For example:
> 	if (transport == IB) && (link-layer == ETH)
> will now become:
> 	if (query_transport() == IBOE)
> 
> Thus we will be able to get rid of the respective transport and link-layer
> checking, and it will help us to add new protocol/Technology (like OPA) more
> easier, also with the introduced management helpers, IB management logical
> will be more clear and easier for extending.
> 
> Highlights:
>     The patch set covered a wide range of IB stuff, thus for those who are
>     familiar with the particular part, your suggestion would be invaluable ;-)
> 
>     Patch 1#~15# included all the logical reform, 16#~25# introduced the
>     management helpers, 26#~27# do clean up.
> 
>     Patches haven't been tested yet, we appreciate if any one who have these
>     HW willing to provide his Tested-by :-)
> 
>     Doug suggested the bitmask mechanism:
> 	https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23765.html
>     which could be the plan for future reforming, we prefer that to be another
>     series which focus on semantic and performance.
> 
>     This patch-set is somewhat 'bloated' now and it may be a good timing for
>     staging, I'd like to suggest we focus on improving existed helpers and push
>     all the further reforms into next series ;-)
>

Series tested for IPoIB and MAD functionality on qib and mlx4 hardware.

Tested-by: Ira Weiny <ira.weiny@intel.com>

> 
> Proposals:
>     Sean:
> 	https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23339.html
>     Doug:
> 	https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23418.html
> 	https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23765.html
>     Jason:
> 	https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23425.html
> 
> Michael Wang (27):
>     IB/Verbs: Implement new callback query_transport()
>     IB/Verbs: Implement raw management helpers
>     IB/Verbs: Reform IB-core mad/agent/user_mad
>     IB/Verbs: Reform IB-core cm
>     IB/Verbs: Reform IB-core sa_query
>     IB/Verbs: Reform IB-core multicast
>     IB/Verbs: Reform IB-ulp ipoib
>     IB/Verbs: Reform IB-ulp xprtrdma
>     IB/Verbs: Reform IB-core verbs/uverbs_cmd/sysfs
>     IB/Verbs: Reform cm related part in IB-core cma/ucm
>     IB/Verbs: Reform route related part in IB-core cma
>     IB/Verbs: Reform mcast related part in IB-core cma
>     IB/Verbs: Reserve legacy transport type in 'dev_addr'
>     IB/Verbs: Reform cma_acquire_dev()
>     IB/Verbs: Reform rest part in IB-core cma
>     IB/Verbs: Use management helper cap_ib_mad()
>     IB/Verbs: Use management helper cap_ib_smi()
>     IB/Verbs: Use management helper cap_ib_cm()
>     IB/Verbs: Use management helper cap_iw_cm()
>     IB/Verbs: Use management helper cap_ib_sa()
>     IB/Verbs: Use management helper cap_ib_mcast()
>     IB/Verbs: Use management helper cap_ipoib()
>     IB/Verbs: Use management helper cap_read_multi_sge()
>     IB/Verbs: Use management helper cap_af_ib()
>     IB/Verbs: Use management helper cap_eth_ah()
>     IB/Verbs: Clean up rdma_ib_or_iboe()
>     IB/Verbs: Cleanup rdma_node_get_transport()
> 
> ---
>  drivers/infiniband/core/agent.c              |    4 
>  drivers/infiniband/core/cm.c                 |   26 +-
>  drivers/infiniband/core/cma.c                |  328 ++++++++++++---------------
>  drivers/infiniband/core/device.c             |    1 
>  drivers/infiniband/core/mad.c                |   51 ++--
>  drivers/infiniband/core/multicast.c          |   18 -
>  drivers/infiniband/core/sa_query.c           |   41 +--
>  drivers/infiniband/core/sysfs.c              |    8 
>  drivers/infiniband/core/ucm.c                |    5 
>  drivers/infiniband/core/ucma.c               |   27 --
>  drivers/infiniband/core/user_mad.c           |   32 +-
>  drivers/infiniband/core/uverbs_cmd.c         |    6 
>  drivers/infiniband/core/verbs.c              |   33 --
>  drivers/infiniband/hw/amso1100/c2_provider.c |    7 
>  drivers/infiniband/hw/cxgb3/iwch_provider.c  |    7 
>  drivers/infiniband/hw/cxgb4/provider.c       |    7 
>  drivers/infiniband/hw/ehca/ehca_hca.c        |    6 
>  drivers/infiniband/hw/ehca/ehca_iverbs.h     |    3 
>  drivers/infiniband/hw/ehca/ehca_main.c       |    1 
>  drivers/infiniband/hw/ipath/ipath_verbs.c    |    7 
>  drivers/infiniband/hw/mlx4/main.c            |   10 
>  drivers/infiniband/hw/mlx5/main.c            |    7 
>  drivers/infiniband/hw/mthca/mthca_provider.c |    7 
>  drivers/infiniband/hw/nes/nes_verbs.c        |    6 
>  drivers/infiniband/hw/ocrdma/ocrdma_main.c   |    1 
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c  |    6 
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.h  |    3 
>  drivers/infiniband/hw/qib/qib_verbs.c        |    7 
>  drivers/infiniband/hw/usnic/usnic_ib_main.c  |    1 
>  drivers/infiniband/hw/usnic/usnic_ib_verbs.c |    6 
>  drivers/infiniband/hw/usnic/usnic_ib_verbs.h |    2 
>  drivers/infiniband/ulp/ipoib/ipoib_main.c    |   17 -
>  include/rdma/ib_verbs.h                      |  204 +++++++++++++++-
>  net/sunrpc/xprtrdma/svc_rdma_recvfrom.c      |    6 
>  net/sunrpc/xprtrdma/svc_rdma_transport.c     |   51 +---
>  35 files changed, 584 insertions(+), 368 deletions(-)