From: Tatyana Nikolova <Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iw_cxgb4: use wildcard mapping for getting remote addr info
Date: Thu, 7 May 2015 15:23:44 -0500 [thread overview]
Message-ID: <20150507202344.GA3972@TENIKOLO-MOBL2> (raw)
In-Reply-To: <20150507145224.28735.97977.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
Reviewed-by: Tatyana Nikolova <Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Thu, May 07, 2015 at 09:52:24AM -0500, Steve Wise wrote:
> For listening endpoints bound to the wildcard address, we need to pass
> the wildcard address mapping to iwpm_get_remote_info() instead of the
> mapped address of the new child connection.
>
> Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index bb95a6c..3ad8dc7 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -583,18 +583,18 @@ static void c4iw_record_pm_msg(struct c4iw_ep *ep,
> sizeof(ep->com.mapped_remote_addr));
> }
>
> -static int get_remote_addr(struct c4iw_ep *ep)
> +static int get_remote_addr(struct c4iw_ep *parent_ep, struct c4iw_ep *child_ep)
> {
> int ret;
>
> - print_addr(&ep->com, __func__, "get_remote_addr");
> + print_addr(&parent_ep->com, __func__, "get_remote_addr parent_ep ");
> + print_addr(&child_ep->com, __func__, "get_remote_addr child_ep ");
>
> - ret = iwpm_get_remote_info(&ep->com.mapped_local_addr,
> - &ep->com.mapped_remote_addr,
> - &ep->com.remote_addr, RDMA_NL_C4IW);
> + ret = iwpm_get_remote_info(&parent_ep->com.mapped_local_addr,
> + &child_ep->com.mapped_remote_addr,
> + &child_ep->com.remote_addr, RDMA_NL_C4IW);
> if (ret)
> - pr_info(MOD "Unable to find remote peer addr info - err %d\n",
> - ret);
> + PDBG("Unable to find remote peer addr info - err %d\n", ret);
>
> return ret;
> }
> @@ -2420,7 +2420,7 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb)
> }
> memcpy(&child_ep->com.remote_addr, &child_ep->com.mapped_remote_addr,
> sizeof(child_ep->com.remote_addr));
> - get_remote_addr(child_ep);
> + get_remote_addr(parent_ep, child_ep);
>
> c4iw_get_ep(&parent_ep->com);
> child_ep->parent_ep = parent_ep;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-07 20:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 14:52 [PATCH] iw_cxgb4: use wildcard mapping for getting remote addr info Steve Wise
[not found] ` <20150507145224.28735.97977.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2015-05-07 15:20 ` Doug Ledford
2015-05-07 15:43 ` Nikolova, Tatyana E
2015-05-07 20:23 ` Tatyana Nikolova [this message]
2015-05-07 20:45 ` Jason Gunthorpe
[not found] ` <20150507204508.GA1195-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-07 21:00 ` Steve Wise
[not found] ` <554BD282.7060800-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2015-05-07 21:09 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507202344.GA3972@TENIKOLO-MOBL2 \
--to=tatyana.e.nikolova-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox