Re: [PATCH 5/5] IB/core: Convert management helpers to core capability bits

["ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Thu, May 14, 2015 at 04:10:24PM +0000, Weiny, Ira wrote:
> > >  static inline bool rdma_protocol_ib(struct ib_device *device, u8
> > > port_num)  {
> > > -	return device->query_protocol(device, port_num) ==
> > RDMA_PROTOCOL_IB;
> > > +	return device->port_immutable[port_num].core_cap_flags &
> > > +RDMA_CORE_CAP_PROT_IB;
> > >  }
> > >
> > >  static inline bool rdma_protocol_iboe(struct ib_device *device, u8
> > > port_num)
> > 
> > Should this helper be renamed rdma_protocol_roce (and change any
> > consumers of this helper to use that name) ? If so, should it be done in this
> > patch or follow on patch ?
> > 
> 
> I'll create a follow on patch.
> 

Since we are going down this path perhaps someone can change all the other iboe
references.  These counts were after changing the rdma_protocol_* names.

12:24:45 > grep -r iboe drivers/infiniband/ | grep -v Binary | wc -l
123

12:24:51 > grep -r iboe include/rdma | grep -v Binary | wc -l
4

Ira

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html