From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v4 for-next 03/12] IB/core: Find the network namespace matching connection parameters Date: Tue, 19 May 2015 12:26:16 -0600 Message-ID: <20150519182616.GF18675@obsidianresearch.com> References: <1431841868-28063-1-git-send-email-haggaie@mellanox.com> <1431841868-28063-4-git-send-email-haggaie@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1431841868-28063-4-git-send-email-haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Haggai Eran Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liran Liss , Guy Shapiro , Shachar Raindel , Yotam Kenneth List-Id: linux-rdma@vger.kernel.org > + list_for_each_entry_rcu(client, &client_list, list) > + if (client->get_net_device_by_port_pkey_ip) { > + ret = client->get_net_device_by_port_pkey_ip(dev, port, > + pkey, > + > addr); Considering the patch that introduced the rwsem, this doesn't look right. We can't call a client call back on a device that is unregistered, we can't call a client call back on a client that is unregistering. So the ordering of the list_del/add vs call back calls in device.c is not right, please audit everything with an eye toward maintaing sane invarients. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html