From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH for-next 09/10] IB/mlx4: Add timestamp_mask and hca_core_clock to query_device Date: Tue, 19 May 2015 12:58:01 -0600 Message-ID: <20150519185801.GM18675@obsidianresearch.com> References: <1431869786-6308-1-git-send-email-ogerlitz@mellanox.com> <1431869786-6308-10-git-send-email-ogerlitz@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1431869786-6308-10-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Amir Vadai , Tal Alon , Matan Barak , Yann Droneaud List-Id: linux-rdma@vger.kernel.org On Sun, May 17, 2015 at 04:36:25PM +0300, Or Gerlitz wrote: > From: Matan Barak > > mlx4 needs to report the number of supported timestamp > bits (mask) and the hca_core_clock frequency. This is critical information to parse the timestamp, why is it hidden in vendor specific land? We can't really look at the uapi changes here without also seeing the verbs side changes. I'd like to see Yann review all the uapi stuff as well. I'm not sure how much I like this idea of appending vendor stuff to these replies... Hiding uapi in a driver just seems like asking for trouble. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html