From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH for-next 08/10] IB/mlx4: Add support for timestamp in cq creation Date: Wed, 20 May 2015 11:27:09 -0600 Message-ID: <20150520172709.GA28496@obsidianresearch.com> References: <1431869786-6308-1-git-send-email-ogerlitz@mellanox.com> <1431869786-6308-9-git-send-email-ogerlitz@mellanox.com> <20150519185527.GL18675@obsidianresearch.com> <555C4C45.7010300@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <555C4C45.7010300-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: Or Gerlitz , Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Amir Vadai , Tal Alon , Matan Barak List-Id: linux-rdma@vger.kernel.org On Wed, May 20, 2015 at 11:56:37AM +0300, Sagi Grimberg wrote: > On 5/19/2015 9:55 PM, Jason Gunthorpe wrote: > >On Sun, May 17, 2015 at 04:36:24PM +0300, Or Gerlitz wrote: > >>@@ -110,6 +110,7 @@ struct mlx4_ib_cq { > >> struct mutex resize_mutex; > >> struct ib_umem *umem; > >> struct ib_umem *resize_umem; > >>+ int create_flags; > > > >flags is u32 > > Maybe even u64 so we wont run out of bits like we did in > device_cap_flags. It is all internal so the bitwidth doesn't matter, we can change it. My remark was because the definitions of flags in the other structure is u32, and copying u32 to int is sloppy. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html