Re: [PATCH for-next 09/10] IB/mlx4: Add timestamp_mask and hca_core_clock to query_device

Jason Gunthorpe
2015-05-26T18:53:15Z

On Tue, May 26, 2015 at 09:33:18PM +0300, Or Gerlitz wrote:
> On Tue, May 26, 2015 at 7:06 PM, Jason Gunthorpe
> <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
> > On Tue, May 26, 2015 at 11:10:45AM +0300, Or Gerlitz wrote:
> >
> >> Jason, ping, it's fair to require that if you made a review argument against
> >> the design done here and we've responded about a week ago, saying why
> >> this design is valid (e.g goes along the 10y old IB stack udata mechanism and
> >> such) -- you would comment on the response and not leave it in the air.
> >
> > Was it not clear? Yann and I asked to see the user space side before
> > reviewing this series further.
>
> Jason, you (U2 BTW) play really, really hard - refusing to say **one**
> word on your approach towards the built-in udata mechanism for uverbs
> which I asked you to comment on.

And I asked to see the user space side and you have angrily refused
every time.

So I guess we are both playing hard.

FWIW, your comments on udata seemed compelling, but I want to see the
whole solution before saying I'm OK with it.

Jason