Re: [PATCH for-next 09/10] IB/mlx4: Add timestamp_mask and hca_core_clock to query_device

Or Gerlitz
2015-05-19T19:30:00Z

On Tue, May 19, 2015 at 10:15 PM, Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
> On Tue, May 19, 2015 at 10:11:43PM +0300, Or Gerlitz wrote:
>> > Sorry, direct this toward the page offset in the next patch.
>>
>> We see this as a piece of detail related to the specific vendor
>> driver. I don't see the point of overloading the user space verbs
>> library or app with an API to get the offset of the clock within the
>> mmap page and such, do you?
>
> Can't you find a better place for this than overloading the
> query_device call? I'd rather see you add some kind of driver-specific
> command than this.

Let's be precise --

Are you objecting adding the clock frequency and mask to the qeury device verb?
why?

If not, are objecting using the vendor specific track of the verb to
pass from the vendor driver to the vendor library this or that detail
which is needed for proper operation? why?