Re: [PATCH for-next 09/10] IB/mlx4: Add timestamp_mask and hca_core_clock to query_device

Jason Gunthorpe
2015-05-27T22:21:08Z

On Thu, May 28, 2015 at 12:33:58AM +0300, Or Gerlitz wrote:

> (2) instantly rejecting a usage of a mechanism existing just for that
> use case since the first year of our life (2005)

I didn't reject anything, I said I wanted to see the user side to
continue my review.

> This series is (1) simple compared to other stuff being reviewed here
> nowadays,

What? It is 11 patches, long, introduces several UAPI changes, does
not implement a standardized feature, adds new uses of latent kernel
functions and exists to support a unique feature of a single hardware
vendor that few understand the usecase for.

I would describe this as one of the toughest to review series on
patchworks right now.

Jason