Re: [PATCH for-next 08/10] IB/mlx4: Add support for timestamp in cq creation

Or Gerlitz
2015-05-20T14:43:57Z

On 5/20/2015 11:56 AM, Sagi Grimberg wrote:
> On 5/19/2015 9:55 PM, Jason Gunthorpe wrote:
>> On Sun, May 17, 2015 at 04:36:24PM +0300, Or Gerlitz wrote:
>>> @@ -110,6 +110,7 @@ struct mlx4_ib_cq {
>>> struct mutex resize_mutex;
>>> struct ib_umem *umem;
>>> struct ib_umem *resize_umem;
>>> + int create_flags;
>>
>> flags is u32
>
> Maybe even u64 so we wont run out of bits like we did in
> device_cap_flags.

Horses hold, you are comparing the volume of the whole feature set
exposed by the RDMA subsystem to user-space vs the number of future CQ
creation flags? I bet we will not have > 8 of them till 2020 and the
framework used for this uverb command is extendable...