Re: [PATCH for-next 08/10] IB/mlx4: Add support for timestamp in cq creation

Jason Gunthorpe
2015-05-20T17:27:09Z

On Wed, May 20, 2015 at 11:56:37AM +0300, Sagi Grimberg wrote:
> On 5/19/2015 9:55 PM, Jason Gunthorpe wrote:
> >On Sun, May 17, 2015 at 04:36:24PM +0300, Or Gerlitz wrote:
> >>@@ -110,6 +110,7 @@ struct mlx4_ib_cq {
> >> struct mutex resize_mutex;
> >> struct ib_umem *umem;
> >> struct ib_umem *resize_umem;
> >>+ int create_flags;
> >
> >flags is u32
>
> Maybe even u64 so we wont run out of bits like we did in
> device_cap_flags.

It is all internal so the bitwidth doesn't matter, we can change
it. My remark was because the definitions of flags in the other
structure is u32, and copying u32 to int is sloppy.

Jason