Re: [PATCH for-next 09/10] IB/mlx4: Add timestamp_mask and hca_core_clock to query_device

Jason Gunthorpe
2015-05-20T17:37:18Z

On Wed, May 20, 2015 at 05:11:17PM +0200, Yann Droneaud wrote:
> Hi,
>
> Le mercredi 20 mai 2015 à 17:41 +0300, Or Gerlitz a écrit :
> > On 5/20/2015 3:29 AM, Jason Gunthorpe wrote:
> > > On Tue, May 19, 2015 at 10:30:00PM +0300, Or Gerlitz wrote:
> > > > > Are you objecting adding the clock frequency and mask to the
> > > > > qeury device verb?
> > > > > why?
> > > Lets see the verbs side and I'll let you know.
> >
> > You mean the user series of libibverbs/libmlx4? I don't see why this
> > should be a must for the review of the kernel bits. The user-space
> > code
> > is coming up soon, sure, but we should be able to review kernel
> > patches
> > without requiring to actually see the user-space code.
> >
>
> In some other subsystems: no userspace code, no merge.
>
> http://blog.ffwll.ch/2015/05/gfx-kernel-upstreaming-requirements.html

I think we need to have the same policy.

Like for the time base related values, if the uapi is some kind of
'ibv_get_wc_timestamp_ns' call (which would make sense) then those are
actually vendor values and we don't need them in the public structure.

Jason