Re: [PATCH for-next 09/10] IB/mlx4: Add timestamp_mask and hca_core_clock to query_device

Jason Gunthorpe
2015-05-19T18:58:01Z

On Sun, May 17, 2015 at 04:36:25PM +0300, Or Gerlitz wrote:
> From: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> mlx4 needs to report the number of supported timestamp
> bits (mask) and the hca_core_clock frequency.

This is critical information to parse the timestamp, why is it hidden
in vendor specific land?

We can't really look at the uapi changes here without also seeing the
verbs side changes.

I'd like to see Yann review all the uapi stuff as well.

I'm not sure how much I like this idea of appending vendor stuff to
these replies... Hiding uapi in a driver just seems like asking for
trouble.

Jason