Re: [PATCH for-next V2 8/9] IB/mlx4: Support extended create_cq and query_device uverbs

[Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]

On Tue, Jun 02, 2015 at 10:21:47AM +0300, Matan Barak wrote:
> On Mon, Jun 1, 2015 at 7:56 PM, Jason Gunthorpe
> <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
> > On Sun, May 31, 2015 at 03:14:16PM +0300, Or Gerlitz wrote:
> >> From: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >>
> >> Add support for ib_uverbs_ex_create_cq and ib_uverbs_ex_query_device
> >> by setting the appropriate bit in uverbs_ex_cmd_mask.
> >
> > Why is this a seperate patch? Surely the bits should be or'd in the patches
> > that actually include the code to do the new commands?
> >
> 
> Although this patch can stand on its own (requesting unsupported flags
> will just fail and the
> comp_mask of uhw's will be disabled), there's no real value for not
> squashing it into the other mlx4 patches.

Then there is something wrong with this 'uverbs_ex_cmd_mask' stuff -
the bit should be clear if the driver cannot handle the ex inputs, but
these patches make all drivers handle the ex style (by checking
flags), so all drivers should have some of the bits set..

An extended command that doesn't use any extended features should
transparently degrade to the normal command as often as possible.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html