public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Matan Barak <matanb-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Somnath Kotur
	<Somnath.Kotur-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>,
	Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v4 for-next 07/14] IB/core: GID attribute should be returned from verbs API and cache API
Date: Tue, 2 Jun 2015 11:39:56 -0600	[thread overview]
Message-ID: <20150602173956.GC17776@obsidianresearch.com> (raw)
In-Reply-To: <CAAKD3BALO6ts66Q0n-BVFz4Niu7L6jX0N-GHLXGp0DQ7Z7c9HA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Tue, Jun 02, 2015 at 07:13:00PM +0300, Matan Barak wrote:

> ib_find_cached_gid is used in cm_init_av_by_path. ndev is necessary
> in order to find the correct GID in the GID table, as otherwise if two upper
> devices has the same IP (hence GID), we might not found the bounded
> device correctly.

But this is exactly what the current state of affairs is, right?

> In addition, vendors need to get the MAC of the ndev that relates to the GID
> in order to output a correct Ethernet header. This is currently done though
> ib_get_cached_gid. Without adding gid_attr, you get a buggy implementation
> that upper devices with different HW addresses would all map to the same MAC.

Again, that is current state of affairs, so this change is a bug fix.

And, we don't expect macvlan to work today with RDMA, so it isn't even
a bug fix, it is a feature add.

And.. given the patches I've seen for roce namespaces, I'm not even
convinced this is the right API approach.

So, save it for the roce namespace support discussion, and we can
figure out how to comprehsively deal with multiple netdevs and
roce.

Otherwise, keep with the current code's assumption that there is
on netdev for each roce device.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-06-02 17:39 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 14:27 [PATCH v4 for-next 00/14] RoCE GID management Matan Barak
     [not found] ` <1432045637-9090-1-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-19 14:27   ` [PATCH v4 for-next 01/14] IB/core: Add RoCE GID table Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 02/14] IB/core: Replace device_mutex with rwsem Matan Barak
     [not found]     ` <1432045637-9090-3-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-19 17:36       ` Jason Gunthorpe
     [not found]         ` <20150519173647.GA18675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-20 16:07           ` Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 03/14] IB/core: Add RoCE GID population Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 04/14] IB/core: Add default GID for RoCE GID table Matan Barak
     [not found]     ` <1432045637-9090-5-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-19 17:41       ` Jason Gunthorpe
     [not found]         ` <20150519174159.GB18675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-20 16:09           ` Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 05/14] net: Add info for NETDEV_CHANGEUPPER event Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 06/14] IB/core: Add RoCE table bonding support Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 07/14] IB/core: GID attribute should be returned from verbs API and cache API Matan Barak
     [not found]     ` <1432045637-9090-8-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-19 18:06       ` Jason Gunthorpe
     [not found]         ` <20150519180649.GC18675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-20 16:27           ` Matan Barak
     [not found]             ` <CAAKD3BAifeMcHbDwcaK7F6cjj=mAn3W0Ms2mOmoXDhaquFqKTA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-20 18:17               ` Jason Gunthorpe
     [not found]                 ` <20150520181718.GD28496-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-28 13:50                   ` Matan Barak
     [not found]                     ` <CAAKD3BDJtpEhfhsB=o4hc=ARWMt7JgpqvbjXJVvsL_vLZRn8yQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-28 16:07                       ` Jason Gunthorpe
     [not found]                         ` <20150528160748.GC2962-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-28 16:34                           ` Or Gerlitz
     [not found]                             ` <5567439C.7080700-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-28 17:07                               ` Jason Gunthorpe
     [not found]                                 ` <20150528170711.GA4345-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-06-02 16:13                                   ` Matan Barak
     [not found]                                     ` <CAAKD3BALO6ts66Q0n-BVFz4Niu7L6jX0N-GHLXGp0DQ7Z7c9HA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-02 17:39                                       ` Jason Gunthorpe [this message]
2015-05-19 14:27   ` [PATCH v4 for-next 08/14] IB/core: Report gid_type and gid_ndev through sysfs Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 09/14] IB/core: Support find sgid index using a filter function Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 10/14] IB/core: Modify ib_verbs and cma in order to use roce_gid_table Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 11/14] RDMA/ocrdma: Changes in driver to incorporate the moving of GID Table mgmt to IB/Core Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 12/14] net/mlx4: Postpone the registration of net_device Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 13/14] IB/mlx4: Implement ib_device callbacks Matan Barak
2015-05-19 14:27   ` [PATCH v4 for-next 14/14] IB/mlx4: Replace mechanism for RoCE GID management Matan Barak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150602173956.GC17776@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=Somnath.Kotur-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matanb-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox