Re: [PATCH v7 0/6] Generic logging helpers

["ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Mon, May 18, 2015 at 01:40:27PM +0300, Sagi Grimberg wrote:
> This small set adds some meaningful verbosity to some
> of the core/rdma_cm enumerated events. Its useful to
> see the meaning of the opcodes instead of revisiting the
> code for every new status/event that left the cache in
> our brain.
> 
> Many thanks to all the reviewers!

I'm really happy to see a series like this.  We need clean up like this to make
working on the stack easier.  Thanks!

Except for Seans comment and mine about the strings breaking lines...

Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>


> 
> Changes from v6:
> - Lowered case for unrecognised event/status print
> - Fixed typo in IB_WC_REM_INV_REQ_ERR string
> 
> Changes from v5:
> - Changed message strings to match the xprtrdma style
> - checkpatch nit
> 
> Changes from v4:
> - Split up ULP changes to separate patches
> 
> Changes from v3:
> - Protect against "holes" in string arrays
> - Restored __attribute_const__ to functions prototype
> - Made string arrays rodata
> 
> Changes from v2:
> - Cast to size_t instead of unsigned
> - Style fix in string arrays declaration
> - Removed redundant __attribute_const__
> 
> Changes from v1:
> - Changed helper names ib_wc_status_msg and rdma_event_msg
> - Cast input arguments to protect string buffer access
> - Add svcrdma to the party
> 
> Changes from v0 (RFC):
> - Moved string arrays to .c files
> - Changed string helpers from macros to exported functions
> - Aligned rds to generic helpers as well
> 
> Sagi Grimberg (6):
>   IB/core, cma: Nice log-friendly string helpers
>   IB/srp: Align to generic logging helpers
>   IB/iser: Align to generic logging helpers
>   iser-target: Align to generic logging helpers
>   xprtrdma, svcrdma: Switch to generic logging helpers
>   RDS: Switch to generic logging helpers
> 
>  drivers/infiniband/core/cma.c            |   28 +++++++++
>  drivers/infiniband/core/verbs.c          |   65 +++++++++++++++++++++
>  drivers/infiniband/ulp/iser/iser_verbs.c |   28 ++++++---
>  drivers/infiniband/ulp/isert/ib_isert.c  |   19 ++++--
>  drivers/infiniband/ulp/srp/ib_srp.c      |   16 +++--
>  include/rdma/ib_verbs.h                  |    4 +
>  include/rdma/rdma_cm.h                   |    2 +
>  net/rds/af_rds.c                         |    9 ---
>  net/rds/ib.h                             |    1 -
>  net/rds/ib_cm.c                          |   36 +-----------
>  net/rds/ib_recv.c                        |    4 +-
>  net/rds/ib_send.c                        |   38 +------------
>  net/rds/rdma_transport.c                 |   34 +----------
>  net/rds/rds.h                            |    1 -
>  net/sunrpc/xprtrdma/frwr_ops.c           |    4 +-
>  net/sunrpc/xprtrdma/svc_rdma_transport.c |   29 ++++++----
>  net/sunrpc/xprtrdma/verbs.c              |   90 ++----------------------------
>  17 files changed, 174 insertions(+), 234 deletions(-)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html