Re: [PATCH v7 5/6] xprtrdma, svcrdma: Switch to generic logging helpers

["ira. weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Mon, Jun 08, 2015 at 11:15:04AM +0300, Sagi Grimberg wrote:
> On 6/7/2015 9:00 AM, ira.weiny wrote:
> >>@@ -201,9 +202,10 @@ static void qp_event_handler(struct ib_event *event, 
> >>void *context)
> >>  	case IB_EVENT_QP_ACCESS_ERR:
> >>  	case IB_EVENT_DEVICE_FATAL:
> >>  	default:
> >>-		dprintk("svcrdma: QP ERROR event %d received for QP=%p, "
> >>+		dprintk("svcrdma: QP ERROR event %s (%d) received for QP=%p, 
> >>"
> >>  			"closing transport\n",
> >
> >
> >Generally it is recommended to keep strings on a single line for easier
> >grepping of the code.
> >
> >"However, never break user-visible strings such as printk messages, because
> >that breaks the ability to grep for them."
> 
> Hey Ira,
> 
> Note that this patch did not cause the line split so I prefer that this
> nit will be addressed in a later patch (along with the rest of the
> file/module).

I am ok with that.

Ira

> 
> Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html