Re: [PATCH for-next V5 05/12] IB/core: Add default GID for RoCE GID table

Matan Barak
2015-06-11T15:30:14Z

On Thu, Jun 11, 2015 at 9:20 AM, Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
> On Mon, Jun 08, 2015 at 05:12:08PM +0300, Matan Barak wrote:
>
>> +unsigned long roce_gid_type_mask_support(struct ib_device *ib_dev, u8 port);
>> +
>
> What is all this gid_type_mask stuff about? rocev2?
>
>> +unsigned long roce_gid_type_mask_support(struct ib_device *ib_dev, u8 port)
>> +{
>> + return !!rdma_protocol_roce(ib_dev, port);
>> +}
>
> Just return bool and drop the !!

I'll change that to bool.

>
> Jason

Matan

> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html