From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v5 1/1] ibacm: Add support for pathrecord query through netlink Date: Thu, 11 Jun 2015 11:59:40 -0600 Message-ID: <20150611175940.GD20142@obsidianresearch.com> References: <1434042265-5066-1-git-send-email-kaike.wan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1434042265-5066-1-git-send-email-kaike.wan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: kaike.wan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, John Fleck , Ira Weiny List-Id: linux-rdma@vger.kernel.org On Thu, Jun 11, 2015 at 01:04:25PM -0400, kaike.wan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > +static int acm_nl_parse_path_attr(struct nlattr *attr, > + struct acm_ep_addr_data *data) > + switch (attr->nla_type & NLA_TYPE_MASK) { > + default: > + acm_log(1, "WARN: unknown attr %x\n", attr->nla_type); > + ret = -1; > + break; I would like to see a mandatory/optional scheme here. For instance if we add SL it would be mandatory, but policy information like requesting net_device would be optional. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html