Re: [PATCH 06/41] IB/hfi1: add char device instantiation code

Jason Gunthorpe
2015-06-15T18:13:48Z

On Mon, Jun 15, 2015 at 06:11:02PM +0000, Hefty, Sean wrote:
> > Was Al Viro's comment on qib addressed here? That would be a
> > showstopper for me..
>
> Do you have a link to this comment? I'm missing a bunch of messages from this thread and can't find anything from Al in the logs.

Author: Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
Date: Sat Apr 4 00:11:32 2015 -0400

infinibad: weird APIs switched to ->write_iter()

Things Not To Do When Writing A Driver, part 1001st:
have writev() and write() on the same file doing completely
different things. As in, "interpret very different sets of
commands".

We _can_ handle that, but it's a bloody bad idea.
Don't do that in new drivers. Ever.

Signed-off-by: Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>

Jasn