RE: [PATCH 00/41] Add OPA gen1 driver

Hefty, Sean
2015-06-17T15:57:39Z

> Ummm.. Could we get some more descriptions as to what this code is for?
>
> Do we have a new OmniPath protocol here as well or is it IB? Which
> standards are followed?
>
> I think the APIs that the driver uses need to be documented somewhere in
> particular if new sysfs entries etc are created.
>
> Are there any user space tools to control/exercise the driver and the
> protocol stack?

Christoph's questions are fair. There should at least be a short write-up that describes how this driver fits into the RDMA stack. (Maybe there are links with additional details that could be provided?) For example, we know from Ira's patches and comments that OPA uses IB like management and supports the same verbs as the qib driver. It's hard to piece this together from separate email threads or by looking at 56,000 lines of code. I'm less concerned about the PSM support myself, as that's self-contained to this driver and doesn't impact the rest of the stack. But at least clarify how it relates to other kernel modules (ib_cm, rdma_cm, ipoib, etc.), if at all.

- Sean