Re: [PATCH 38/41] IB/hfi1: add general verbs handling

Christoph Lameter
2015-06-12T19:10:58Z

On Thu, 11 Jun 2015, Mike Marciniszyn wrote:

> +static int query_device(struct ib_device *ibdev,
> + struct ib_device_attr *props)
> +{
> + struct hfi1_devdata *dd = dd_from_ibdev(ibdev);
> + struct hfi1_ibdev *dev = to_idev(ibdev);
> +
> + memset(props, 0, sizeof(*props));
> +
> + props->device_cap_flags = IB_DEVICE_BAD_PKEY_CNTR |
> + IB_DEVICE_BAD_QKEY_CNTR | IB_DEVICE_SHUTDOWN_PORT |
> + IB_DEVICE_SYS_IMAGE_GUID | IB_DEVICE_RC_RNR_NAK_GEN |
> + IB_DEVICE_PORT_ACTIVE_EVENT | IB_DEVICE_SRQ_RESIZE;

Hmmm... One thing that we need here is:

IB_DEVICE_BLOCK_MULTICAST_LOOPBACK

to avoid the flow back of large multicast streams. Looks like this is
IB/OP only. If you support ethernet then other flags are required too.

> + props->page_size_cap = PAGE_SIZE;

No large page support?