Re: [PATCH for-next V6 00/10] Move RoCE GID management to IB/Core

Or Gerlitz
2015-06-25T08:34:43Z

On Wed, Jun 24, 2015 at 3:59 PM, Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
[...]
> Changes from V5:
> (1) Incoporate the changes to cache.c so we use the same infrastructure
> to manage both IB and RoCE (per Doug's request)
> (2) Replace the locking mechanism in the IB core GID cache from seqcount +
> rcu to rwlock (addressing comments from Jason)
> (3) get_netdev returns a helded (dev_hold) device
> (4) Squashed the RocE GID table, RoCE GID management and default GID handling
> code into one patch (per Doug's request).
> (5) Change modify_gid to add_gid and del_gid.
> (6) set the netdev related changes into three dedicated patches and make
> them be 1st in the series.

Hi Jason, Doug,

So... are we finally OK wrt the feedback you provided?

Matan and team have carefully addressed the review comments, let us
know how you see this
(same for Haggai's V1 series post, will love to get your feedback to
know where we are there too).

Or.

> Changes from V4:
> (1) Remove any API changes.
> (2) Fixed a bug regarding bonding upper devices.
> (3) Rebased ontop of Doug's k.o/for-4.2.
>
> Changes from V3:
> (1) Remove RoCE V2 functionality (it will be sent at later patchset).
> (2) Instead of removing qp_attr_mask flags, reserve them.
> (3) Remove the kref from IB devices in favor of rwsem.
> (4) Change the name of roce_gid_cache to roce_gid_table.
> (5) Fix a race when roce_gid_table is free'd while getting events.
> (6) Remove the roce_gid_cache active/inactive flag/API.