Re: [PATCH for-next V6 00/10] Move RoCE GID management to IB/Core

Or Gerlitz
2015-06-29T14:07:36Z

On Thu, Jun 25, 2015 at 9:13 PM, Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
> On Thu, Jun 25, 2015 at 11:34:43AM +0300, Or Gerlitz wrote:
>
>> So... are we finally OK wrt the feedback you provided?
>
> I've been looking at Yishai's series, I though it was almost good to
> go, but the error flows are still wrong :(
>
> For Matan's patch, I only looked briefly, merging it with the other
> file made the diffs super hard to read for some reason. But I think it
> is the right series now, and covers the right ground..
>
> Very superficially the locking looks improved I am happy to see the
> wonky smb_rmb stuff gone as well. But I stopped reading the first
> series after I saw the bad use of rcu, so who knows what else in
> there..
>
> Haven't even looked at Haggai's patch considering the other two are
> ahead of it. It seemed like it was covering the right ground too.
>
> I'll try and read one of them next week, hopefully others will comment
> in the mean time.

Jason,

You were the major reviewer for Haggai's series, and he worked hard to
address your comments, so now it's the last mile, seeing that the
feedback has been applied, I don't see the point of throwing new
reviewers in and starting it altogether, this would also be unfair
towards the developers, I guess Sean can comment too (since this
touches the CMA/CM) if he wants to, but I can't force him to do so. As
for Matan's series, same. You and Doug were the main reviewers and
Matan worked over-hours to address the feedback and it was followed by
2nd/3rd internal review on the locking comments. Doug asked the cache
changes to be in one patch and this is how we did it. This is running
here for months, and I think we're good to go upstream now, in the
sense that the reviewers comments were addresses, so...

Or.